Skip to content

perf: Fall back to ordering by bq pk when possible #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 3, 2025
Merged

perf: Fall back to ordering by bq pk when possible #1350

merged 6 commits into from
Feb 3, 2025

Conversation

@TrevorBergeron
Copy link
Contributor

@TrevorBergeron TrevorBergeron commented Feb 1, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Feb 1, 2025
@TrevorBergeron TrevorBergeron requested a review from tswast February 1, 2025 02:28
@TrevorBergeron TrevorBergeron marked this pull request as ready for review February 1, 2025 02:29
@TrevorBergeron TrevorBergeron requested review from a team as code owners February 1, 2025 02:29
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Feb 3, 2025
tswast
tswast reviewed Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit on naming, otherwise looks good!
bigframes/session/_io/bigquery/read_gbq_table.py
return index_cols


def get_time_travel_datetime_and_table_metadata(
Copy link
Collaborator

@tswast tswast Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code?
Copy link
Contributor Author

@TrevorBergeron TrevorBergeron Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, dead and now, gone
tswast
tswast reviewed Feb 3, 2025
View reviewed changes
@TrevorBergeron TrevorBergeron enabled auto-merge (squash) February 3, 2025 21:56
@TrevorBergeron TrevorBergeron merged commit 3c4abf2 into main Feb 3, 2025
22 of 23 checks passed
@TrevorBergeron TrevorBergeron deleted the use_pk_always branch February 3, 2025 22:46
@release-please release-please bot mentioned this pull request Feb 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

4 participants

@TrevorBergeron @tswast @shobsi