Skip to content

fix: resolve plotly rendering issue by using ipython html for job pro… #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 26, 2023
Merged

fix: resolve plotly rendering issue by using ipython html for job pro… #134

merged 5 commits into from
Oct 26, 2023

Conversation

@orrbradford
Copy link
Contributor

@orrbradford orrbradford commented Oct 23, 2023 •
edited by shobsi
Loading

…gress messages

Fixes bug that was preventing plotly rendering to show after the progress bar. Original ipywidgets implementation isn't necessary for basic opening of urls

Screen recording: https://github.com/googleapis/python-bigquery-dataframes/assets/15842009/5225ce05-117a-4808-9ff0-cb2c3aaf3a40

Internal bug: b/297062404
@orrbradford orrbradford requested review from a team as code owners October 23, 2023 22:35
@orrbradford orrbradford requested a review from shobsi October 23, 2023 22:35
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 23, 2023
@shobsi
Copy link
Contributor

shobsi commented Oct 24, 2023

…gress messages

Fixes bug that was preventing plotly rendering to show after the progress bar. Original ipywidgets implementation isn't necessary for basic opening of urls

Screen recording: https://github.com/googleapis/python-bigquery-dataframes/assets/15842009/5225ce05-117a-4808-9ff0-cb2c3aaf3a40

Is this recording after your change? If yes, wondering what was the issue before?
@orrbradford
Copy link
Contributor Author

orrbradford commented Oct 24, 2023

…gress messages
Fixes bug that was preventing plotly rendering to show after the progress bar. Original ipywidgets implementation isn't necessary for basic opening of urls
Screen recording: https://github.com/googleapis/python-bigquery-dataframes/assets/15842009/5225ce05-117a-4808-9ff0-cb2c3aaf3a40

Is this recording after your change? If yes, wondering what was the issue before?

The plotly graph didn't render at all. Running theory is that this was due to ipywidgets interactive nature. There's more explanation in the internal bug report b/297062404.
@orrbradford
fix: resolve plotly rendering issue by using ipython html for job pro…
0e541fb 
…gress messages

Fixes bug that was preventing plotly rendering to show after the progress bar. Original ipywidgets implementation isn't necessary for basic opening of urls

Screencast: https://screencast.googleplex.com/cast/NTU1MDcyMjUxNTk5MjU3Nnw0Njg4MDFiMS1hYw
@orrbradford orrbradford force-pushed the 297062404-use-ipython-html branch from 89e96a9 to 0e541fb Compare October 25, 2023 21:03
@orrbradford orrbradford added the automerge Merge the pull request once unit tests and other checks pass. label Oct 26, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 39df43e into main Oct 26, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the 297062404-use-ipython-html branch October 26, 2023 23:46
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 26, 2023
@release-please release-please bot mentioned this pull request Oct 26, 2023
Merged
ashleyxuu pushed a commit that referenced this pull request Oct 30, 2023
@orrbradford @ashleyxuu
fix: resolve plotly rendering issue by using ipython html for job pro… (
bbc3c69 
#134)

…gress messages

Fixes bug that was preventing plotly rendering to show after the progress bar. Original ipywidgets implementation isn't necessary for basic opening of urls

Screen recording: https://togithub.com/googleapis/python-bigquery-dataframes/assets/15842009/5225ce05-117a-4808-9ff0-cb2c3aaf3a40

Internal bug: b/297062404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

3 participants

@orrbradford @shobsi