Skip to content

Conversation

@tswast
Copy link
Collaborator

@tswast tswast commented Jan 16, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards internal issues 342210801 and 354940839 and #647
🦕

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jan 16, 2025
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Jan 16, 2025
@tswast tswast marked this pull request as ready for review January 16, 2025 21:06
@tswast tswast requested review from a team as code owners January 16, 2025 21:06
@tswast tswast requested a review from Genesis929 January 16, 2025 21:06
@tswast tswast merged commit aa2f73a into main Jan 17, 2025
22 checks passed
@tswast tswast deleted the b354940839-sql_scalar branch January 17, 2025 21:50
shuoweil pushed a commit that referenced this pull request Jan 20, 2025
…ries objects (#1293)

* feat: add `bigframes.bigquery.sql_scalar()` to apply SQL syntax on Series objects

* add SqlScalarOp

* fix ibis compilation and add a test

* remove error from notebook

* fix mypy

* simplify to use literals in dry run sql

* add support for all types in scalars df

* fix doctest

* fix unit tests and mypy

* add unit tests for literal to SQL
shuoweil pushed a commit that referenced this pull request Jan 20, 2025
…ries objects (#1293)

* feat: add `bigframes.bigquery.sql_scalar()` to apply SQL syntax on Series objects

* add SqlScalarOp

* fix ibis compilation and add a test

* remove error from notebook

* fix mypy

* simplify to use literals in dry run sql

* add support for all types in scalars df

* fix doctest

* fix unit tests and mypy

* add unit tests for literal to SQL
shuoweil pushed a commit that referenced this pull request Jan 24, 2025
…ries objects (#1293)

* feat: add `bigframes.bigquery.sql_scalar()` to apply SQL syntax on Series objects

* add SqlScalarOp

* fix ibis compilation and add a test

* remove error from notebook

* fix mypy

* simplify to use literals in dry run sql

* add support for all types in scalars df

* fix doctest

* fix unit tests and mypy

* add unit tests for literal to SQL
shuoweil pushed a commit that referenced this pull request Jan 24, 2025
…ries objects (#1293)

* feat: add `bigframes.bigquery.sql_scalar()` to apply SQL syntax on Series objects

* add SqlScalarOp

* fix ibis compilation and add a test

* remove error from notebook

* fix mypy

* simplify to use literals in dry run sql

* add support for all types in scalars df

* fix doctest

* fix unit tests and mypy

* add unit tests for literal to SQL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.

4 participants