Skip to content

feat: support context manager for bigframes session #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 29, 2024
Merged

feat: support context manager for bigframes session #1107

merged 5 commits into from
Oct 29, 2024

Conversation

@shobsi
Copy link
Contributor

@shobsi shobsi commented Oct 23, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 372969734 🦕
@shobsi shobsi requested review from a team as code owners October 23, 2024 18:53
@shobsi shobsi requested a review from GarrettWu October 23, 2024 18:53
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 23, 2024
@shobsi shobsi requested review from sycai and tswast and removed request for GarrettWu October 23, 2024 20:11
sycai
sycai approved these changes Oct 25, 2024
View reviewed changes
@shobsi shobsi merged commit 5f7b8b1 into main Oct 29, 2024
23 checks passed
@shobsi shobsi deleted the shobs-rf-ctx-mgr branch October 29, 2024 00:27
@release-please release-please bot mentioned this pull request Oct 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

4 participants

@shobsi @sycai @junyazhang