Skip to content

fix: correct zero row count in DataFrame from table view #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2024
Merged

fix: correct zero row count in DataFrame from table view #1062

merged 2 commits into from
Oct 8, 2024

Conversation

@Genesis929
Copy link
Collaborator

@Genesis929 Genesis929 commented Oct 7, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 7, 2024
@Genesis929 Genesis929 changed the title fix: correct zero row count display in DataFrame from table view fix: correct zero row count in DataFrame from table view Oct 7, 2024
@Genesis929 Genesis929 marked this pull request as ready for review October 7, 2024 23:46
@Genesis929 Genesis929 requested review from a team as code owners October 7, 2024 23:46
@Genesis929 Genesis929 requested a review from shobsi October 7, 2024 23:46
TrevorBergeron
TrevorBergeron reviewed Oct 7, 2024
View reviewed changes
bigframes/core/nodes.py Outdated
table_id=table.table_id,
physical_schema=schema,
n_rows=table.num_rows,
is_view=(table.table_type == "VIEW"),
Copy link
Contributor

@TrevorBergeron TrevorBergeron Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if EXTERNAL and MATERIALIZED_VIEW have the same problem. https://cloud.google.com/python/docs/reference/bigquery/latest/google.cloud.bigquery.table.Table#google_cloud_bigquery_table_Table_table_type
Copy link
Collaborator Author

@Genesis929 Genesis929 Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As chatted offline, MATERIALIZED_VIEW will be skipped for now.

And external table seems also shows row count zero if we read num_rows.

Logic updated.
@Genesis929 Genesis929 enabled auto-merge (squash) October 8, 2024 00:32
@Genesis929 Genesis929 merged commit b536070 into main Oct 8, 2024
22 of 23 checks passed
@Genesis929 Genesis929 deleted the view_shape_fix_huanc branch October 8, 2024 01:14
@release-please release-please bot mentioned this pull request Oct 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

4 participants

@Genesis929 @TrevorBergeron @rey-esp