Skip to content

fix: make invalid location warning case-insensitive #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 3, 2024
Merged

fix: make invalid location warning case-insensitive #1044

merged 4 commits into from
Oct 3, 2024

Conversation

@shobsi
Copy link
Contributor

@shobsi shobsi commented Oct 3, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 371059435 🦕
@shobsi shobsi requested review from a team as code owners October 3, 2024 01:30
@shobsi shobsi requested a review from sycai October 3, 2024 01:30
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 3, 2024
@shobsi shobsi merged commit b6cd55a into main Oct 3, 2024
23 checks passed
@shobsi shobsi deleted the shobs-location-warning branch October 3, 2024 20:51
@release-please release-please bot mentioned this pull request Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

4 participants

@shobsi @sycai @liujiashang