docs: Adding Samples for Adding/Removing File Owners by sydney-munro · Pull Request #1273 · googleapis/java-storage

sydney-munro · 2022-02-24T00:09:19Z

Fixes storage_remove_file_owner b/221108487
Fixes storage_add_file_owner b/221108311

snippet-bot · 2022-02-24T00:09:29Z

Here is the summary of changes.

You are about to add 2 region tags.

samples/snippets/src/main/java/com/example/storage/object/AddFileOwner.java:19, tag storage_add_file_owner
samples/snippets/src/main/java/com/example/storage/object/RemoveFileOwner.java:19, tag storage_remove_file_owner

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

BenWhitehead · 2022-02-24T19:44:11Z

We might need to change the role assigned, since the email used for the service account doesn't have the owner role.

permissions issues need addressing

lesv · 2022-02-25T22:30:03Z

Samples

AddFileOwnerTest(sponge_log).testAddFileOwner

com.google.cloud.storage.StorageException: The owner of the resource is required to have OWNER access.
	at com.google.cloud.storage.spi.v1.HttpStorageRpc.translate(HttpStorageRpc.java:233)
	at com.google.cloud.storage.spi.v1.HttpStorageRpc.createAcl(HttpStorageRpc.java:1320)
	at com.google.cloud.storage.StorageImpl.lambda$createAcl$39(StorageImpl.java:1198)
	at com.google.api.gax.retrying.DirectRetryingExecutor.submit(DirectRetryingExecutor.java:105)
	at com.google.cloud.RetryHelper.run(RetryHelper.java:76)
	at com.google.cloud.RetryHelper.runWithRetries(RetryHelper.java:50)
	at com.google.cloud.storage.Retrying.run(Retrying.java:51)
	at com.google.cloud.storage.StorageImpl.run(StorageImpl.java:1374)
	at com.google.cloud.storage.StorageImpl.createAcl(StorageImpl.java:1198)
	at com.google.cloud.storage.Blob.createAcl(Blob.java:881)
	at com.example.storage.object.AddFileOwner.addFileOwner(AddFileOwner.java:46)
	at com.example.storage.object.AddFileOwnerTest.testAddFileOwner(AddFileOwnerTest.java:35)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at com.google.cloud.testing.junit4.StdXCaptureRule$1.evaluate(StdXCaptureRule.java:78)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:364)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:237)
	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:158)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428)
	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
	at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548)
Caused by: com.google.api.client.googleapis.json.GoogleJsonResponseException: 403 Forbidden
POST https://storage.googleapis.com/storage/v1/b/gcloud-test-bucket-temp-bc35cf9d-2e60-47f3-a00d-05c5c026a6c3/o/blob/acl?generation=1645661716412803
{
  "code" : 403,
  "errors" : [ {
    "domain" : "global",
    "message" : "The owner of the resource is required to have OWNER access.",
    "reason" : "forbidden"
  } ],
  "message" : "The owner of the resource is required to have OWNER access."
}
	at com.google.api.client.googleapis.json.GoogleJsonResponseException.from(GoogleJsonResponseException.java:146)
	at com.google.api.client.googleapis.services.json.AbstractGoogleJsonClientRequest.newExceptionOnError(AbstractGoogleJsonClientRequest.java:118)
	at com.google.api.client.googleapis.services.json.AbstractGoogleJsonClientRequest.newExceptionOnError(AbstractGoogleJsonClientRequest.java:37)
	at com.google.api.client.googleapis.services.AbstractGoogleClientRequest$1.interceptResponse(AbstractGoogleClientRequest.java:428)
	at com.google.api.client.http.HttpRequest.execute(HttpRequest.java:1111)
	at com.google.api.client.googleapis.services.AbstractGoogleClientRequest.executeUnparsed(AbstractGoogleClientRequest.java:514)
	at com.google.api.client.googleapis.services.AbstractGoogleClientRequest.executeUnparsed(AbstractGoogleClientRequest.java:455)
	at com.google.api.client.googleapis.services.AbstractGoogleClientRequest.execute(AbstractGoogleClientRequest.java:565)
	at com.google.cloud.storage.spi.v1.HttpStorageRpc.createAcl(HttpStorageRpc.java:1317)
	... 41 more

RemoveFileOwnerTest(sponge_log).testRemoveFileOwner

com.google.cloud.storage.StorageException: The owner of the resource is required to have OWNER access.
	at com.google.cloud.storage.spi.v1.HttpStorageRpc.translate(HttpStorageRpc.java:233)
	at com.google.cloud.storage.spi.v1.HttpStorageRpc.createAcl(HttpStorageRpc.java:1320)
	at com.google.cloud.storage.StorageImpl.lambda$createAcl$39(StorageImpl.java:1198)
	at com.google.api.gax.retrying.DirectRetryingExecutor.submit(DirectRetryingExecutor.java:105)
	at com.google.cloud.RetryHelper.run(RetryHelper.java:76)
	at com.google.cloud.RetryHelper.runWithRetries(RetryHelper.java:50)
	at com.google.cloud.storage.Retrying.run(Retrying.java:51)
	at com.google.cloud.storage.StorageImpl.run(StorageImpl.java:1374)
	at com.google.cloud.storage.StorageImpl.createAcl(StorageImpl.java:1198)
	at com.google.cloud.storage.Blob.createAcl(Blob.java:881)
	at com.example.storage.object.RemoveFileOwnerTest.testRemoveFileOwner(RemoveFileOwnerTest.java:38)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at com.google.cloud.testing.junit4.StdXCaptureRule$1.evaluate(StdXCaptureRule.java:78)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:364)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:237)
	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:158)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428)
	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
	at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548)
Caused by: com.google.api.client.googleapis.json.GoogleJsonResponseException: 403 Forbidden
POST https://storage.googleapis.com/storage/v1/b/gcloud-test-bucket-temp-e204a06f-b238-4e47-aeb7-d432022bcba1/o/blob/acl?generation=1645661718011107
{
  "code" : 403,
  "errors" : [ {
    "domain" : "global",
    "message" : "The owner of the resource is required to have OWNER access.",
    "reason" : "forbidden"
  } ],
  "message" : "The owner of the resource is required to have OWNER access."
}
	at com.google.api.client.googleapis.json.GoogleJsonResponseException.from(GoogleJsonResponseException.java:146)
	at com.google.api.client.googleapis.services.json.AbstractGoogleJsonClientRequest.newExceptionOnError(AbstractGoogleJsonClientRequest.java:118)
	at com.google.api.client.googleapis.services.json.AbstractGoogleJsonClientRequest.newExceptionOnError(AbstractGoogleJsonClientRequest.java:37)
	at com.google.api.client.googleapis.services.AbstractGoogleClientRequest$1.interceptResponse(AbstractGoogleClientRequest.java:428)
	at com.google.api.client.http.HttpRequest.execute(HttpRequest.java:1111)
	at com.google.api.client.googleapis.services.AbstractGoogleClientRequest.executeUnparsed(AbstractGoogleClientRequest.java:514)
	at com.google.api.client.googleapis.services.AbstractGoogleClientRequest.executeUnparsed(AbstractGoogleClientRequest.java:455)
	at com.google.api.client.googleapis.services.AbstractGoogleClientRequest.execute(AbstractGoogleClientRequest.java:565)
	at com.google.cloud.storage.spi.v1.HttpStorageRpc.createAcl(HttpStorageRpc.java:1317)
	... 40 more

generated-files-bot · 2022-02-28T21:50:38Z

Warning: This pull request is touching the following templated files:

.kokoro/nightly/samples.cfg
.kokoro/presubmit/samples.cfg

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

docs: Adding Samples for Adding/Removing File Owners

6c5a280

sydney-munro added kokoro:run Add this label to force Kokoro to re-run the tests. api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. labels Feb 24, 2022

sydney-munro requested review from BenWhitehead, JesseLovelace and frankyn February 24, 2022 00:09

sydney-munro self-assigned this Feb 24, 2022

yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 24, 2022

sydney-munro requested review from a team February 24, 2022 00:11

BenWhitehead previously approved these changes Feb 24, 2022

View reviewed changes

sydney-munro force-pushed the file-owner branch from 4c5c220 to 14e437b Compare February 25, 2022 23:04

Fixing broken tests

f85c6d8

sydney-munro force-pushed the file-owner branch from 27e5770 to f85c6d8 Compare February 25, 2022 23:15

sydney-munro added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 25, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 25, 2022

sydney-munro force-pushed the file-owner branch 3 times, most recently from 3ce1f31 to f70d72f Compare February 28, 2022 17:52

Trying to fix tests.. again

68aba86

sydney-munro force-pushed the file-owner branch from 43e5f44 to 68aba86 Compare February 28, 2022 21:50

gcf-owl-bot Bot and others added 3 commits February 28, 2022 21:52

🦉 Updates from OwlBot post-processor

e8ad06a

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'main' into file-owner

247ec09

🦉 Updates from OwlBot post-processor

7ee38d1

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

sydney-munro requested a review from BenWhitehead February 28, 2022 22:33

BenWhitehead approved these changes Mar 1, 2022

View reviewed changes

sydney-munro merged commit 6fad19c into main Mar 1, 2022

sydney-munro deleted the file-owner branch March 1, 2022 19:48

release-please Bot mentioned this pull request Mar 1, 2022

chore(main): release 2.4.5 #1280

Merged

release-please Bot mentioned this pull request Aug 10, 2022

chore(main): release 2.11.4 #1564

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: Adding Samples for Adding/Removing File Owners#1273

docs: Adding Samples for Adding/Removing File Owners#1273
sydney-munro merged 6 commits into
mainfrom
file-owner

sydney-munro commented Feb 24, 2022 •

edited by BenWhitehead

Loading

snippet-bot Bot commented Feb 24, 2022 •

edited

Loading

BenWhitehead commented Feb 24, 2022

lesv commented Feb 25, 2022

generated-files-bot Bot commented Feb 28, 2022

Labels

4 participants

Conversation

sydney-munro commented Feb 24, 2022 • edited by BenWhitehead Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

snippet-bot Bot commented Feb 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.