Skip to content

Consider switching to WiX 5.0.2 from WiX 4.0.5 #1070

@yukawa

Description

@yukawa

Description

WiX 5.0.2 was released on Oct 4, 2024.

Unlike WiX 5.0.1, which failed to compile our installer_oss_64bit.wxs, WiX 5.0.2 looks to have no issue on building it without any modification.

Steps to reproduce

Steps to reproduce the behavior:

  1. Replace 4.0.5 with 5.0.2 in the following files.
  • mozc/dotnet-tools.json

    Lines 1 to 12 in ace3145

    {
    "version": 1,
    "isRoot": true,
    "tools": {
    "wix": {
    "version": "4.0.5",
    "commands": [
    "wix"
    ]
    }
    }
    }
  • mozc/src/MODULE.bazel

    Lines 165 to 168 in ace3145

    dotnet_tool_repository(
    name = "wix",
    version = "4.0.5",
    )
  • mozc/src/WORKSPACE.bazel

    Lines 225 to 230 in ace3145

    # dotnet tool repository (to load "wix")
    load("@//bazel:dotnet_tool_repository.bzl", "dotnet_tool_repository")
    dotnet_tool_repository(
    name = "wix",
    version = "4.0.5",
    )
  1. Build Mozc (with either GYP or Bazel)

Expected behavior

There is no difference in Mozc64.msi built.

Actual behavior

There is no difference in Mozc64.msi built.

Version or commit-id

ace3145

Environment

  • OS: Windows 11 23H2

Metadata

Metadata

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions