Overview

Daily lint scan identified 3 file Close() calls not deferred immediately after successful open. This is a resource-leak risk.

Findings

1. pkg/cli/mcp_logs_guardrail.go:87 — File Close() should be deferred immediately
2. pkg/cli/workflows.go:307 — File Close() should be deferred immediately
3. pkg/cli/workflows.go:396 — File Close() should be deferred immediately

Remediation Strategy

Quick fix — defer Close() immediately after successful file open:

// BEFORE
f, err := os.Open(path)
if err != nil {
    return err
}
// ... do work ...
f.Close()  // ❌ Resource leak if error occurs before this line

// AFTER
f, err := os.Open(path)
if err != nil {
    return err
}
defer f.Close()  // ✅ Always closes, even on error
// ... do work ...

Validation Checklist

• Add defer f.Close() immediately after each successful file open
• Ensure error handling path is before defer statement
• Remove explicit Close() calls that are now deferred
• Run make golint-custom — verify zero "resource leak" violations
• Run go test -v ./pkg/cli/ — all pass

Expected Outcome

3 resource-leak violations resolved.

Generated by 🧌 LintMonster · ● hai45 109K · ◷

• expires on May 31, 2026, 3:50 AM UTC