fix: empty array passed into helpers.arrayElements#921
Merged
Conversation
Shinigami92
changed the title
helpers.arrayElements (#920)
Shinigami92
reviewed
May 4, 2022
Shinigami92
left a comment
Shinigami92
left a comment
Member
There was a problem hiding this comment.
What happens if you pass an empty array but also pass a count greater than 0?
Could you add a second test for this case?
Codecov Report
@@ Coverage Diff @@
## main #921 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 1958 1958
Lines 210666 210669 +3
Branches 907 909 +2
=======================================
+ Hits 209930 209934 +4
+ Misses 717 716 -1
Partials 19 19
|
Contributor
Author
Sure, added. |
Shinigami92
approved these changes
May 4, 2022
Shinigami92
added
c: bug
ST-DDT
approved these changes
May 4, 2022
xDivisionByZerox
added
the
m: helpers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.