Skip to content

fix: dont log deprecations on startup#857

Merged
Shinigami92 merged 4 commits into
mainfrom
856-deprecation-messages-are-logged-while-accessing-faker
Apr 21, 2022
Merged

fix: dont log deprecations on startup#857
Shinigami92 merged 4 commits into
mainfrom
856-deprecation-messages-are-logged-while-accessing-faker

Conversation

@Shinigami92

@Shinigami92 Shinigami92 commented Apr 20, 2022

Copy link
Copy Markdown
Member

No description provided.

@Shinigami92 Shinigami92 added c: bug Something isn't working p: 3-urgent Fix and release ASAP s: accepted Accepted feature / Confirmed bug labels Apr 20, 2022
@Shinigami92 Shinigami92 added this to the v6.2 - New small features milestone Apr 20, 2022
@Shinigami92 Shinigami92 self-assigned this Apr 20, 2022
@Shinigami92 Shinigami92 linked an issue Apr 20, 2022 that may be closed by this pull request
Deprecation messages are logged while accessing faker #856
Closed
@Shinigami92 Shinigami92 marked this pull request as ready for review April 20, 2022 18:25
@Shinigami92 Shinigami92 requested a review from a team as a code owner April 20, 2022 18:25
@codecov

codecov Bot commented Apr 20, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #857 (1708e70) into main (fe8eea4) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 1708e70 differs from pull request most recent head c76a12d. Consider uploading reports for the commit c76a12d to get more accurate results

@@            Coverage Diff             @@
##             main     #857      +/-   ##
==========================================
- Coverage   99.35%   99.34%   -0.02%     
==========================================
  Files        1922     1922              
  Lines      183052   183057       +5     
  Branches      900      903       +3     
==========================================
- Hits       181878   181860      -18     
- Misses       1118     1141      +23     
  Partials       56       56
Impacted Files Coverage Δ
src/unique.ts 62.04% <100.00%> (-15.99%) ⬇️
@Shinigami92 Shinigami92 requested a review from a team April 20, 2022 18:51
pkuczynski
pkuczynski previously approved these changes Apr 20, 2022
View reviewed changes
ST-DDT
ST-DDT reviewed Apr 20, 2022
View reviewed changes
Comment thread test/faker.spec.ts Outdated
@ST-DDT ST-DDT added p: 2-high Fix main branch and removed p: 3-urgent Fix and release ASAP labels Apr 20, 2022
@ST-DDT

ST-DDT commented Apr 20, 2022

Copy link
Copy Markdown
Member

AFAICT We haven't released this bug yet, so there is no need for a hotfix release.
@Shinigami92

Shinigami92 commented Apr 21, 2022

Copy link
Copy Markdown
Member Author

AFAICT We haven't released this bug yet, so there is no need for a hotfix release.

I set that to p3 cause it's blocking us from releasing a v6.2.0, but I'm okay with any prio anyways 🤷
@Shinigami92 Shinigami92 requested review from a team, ST-DDT and pkuczynski April 21, 2022 08:06
@ST-DDT ST-DDT requested a review from a team April 21, 2022 13:20
@Shinigami92 Shinigami92 enabled auto-merge (squash) April 21, 2022 18:29
@Shinigami92 Shinigami92 merged commit a28b5de into main Apr 21, 2022
@ST-DDT ST-DDT deleted the 856-deprecation-messages-are-logged-while-accessing-faker branch April 26, 2022 09:48
@ST-DDT ST-DDT mentioned this pull request Apr 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: bug Something isn't working p: 2-high Fix main branch s: accepted Accepted feature / Confirmed bug

4 participants

@Shinigami92 @ST-DDT @pkuczynski @ejcheng