Skip to content

fix: enable algolia search#641

Merged
Shinigami92 merged 3 commits into
faker-js:mainfrom
PrisisForks:feature/algoila
Mar 23, 2022
Merged

fix: enable algolia search#641
Shinigami92 merged 3 commits into
faker-js:mainfrom
PrisisForks:feature/algoila

Conversation

@prisis

@prisis prisis commented Mar 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

I added the env's into netlify
@codecov

codecov Bot commented Mar 21, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #641 (778aebb) into main (7f32614) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #641   +/-   ##
=======================================
  Coverage   99.33%   99.33%           
=======================================
  Files        1923     1923           
  Lines      176853   176853           
  Branches      906      906           
=======================================
  Hits       175681   175681           
  Misses       1116     1116           
  Partials       56       56
@Shinigami92 Shinigami92 added c: docs Improvements or additions to documentation p: 2-high Fix main branch s: accepted Accepted feature / Confirmed bug labels Mar 21, 2022
@Shinigami92

Shinigami92 commented Mar 21, 2022

Copy link
Copy Markdown
Member

I cannot review if it's working due to I do not have the API_KEY in my local envs

Can we somehow test this PR with a netlify preview?
Otherwise, did you test it manually?
griest024
griest024 approved these changes Mar 21, 2022
View reviewed changes

@griest024 griest024 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine but I did not acceptance test. Should this close #222 ?
@Shinigami92 Shinigami92 linked an issue Mar 21, 2022 that may be closed by this pull request
Docs: hook up algolia search #222
Closed
@prisis

prisis commented Mar 23, 2022

Copy link
Copy Markdown
Member Author

Tested it on my local en

Bildschirmaufnahme.2022-03-23.08.26.18.mp4
@Shinigami92 Shinigami92 changed the title fix(#222): enable algolia search again fix: enable algolia search Mar 23, 2022
@Shinigami92 Shinigami92 merged commit a759c87 into faker-js:main Mar 23, 2022
@ST-DDT

ST-DDT commented Mar 23, 2022

Copy link
Copy Markdown
Member

Works like a charm!
@prisis prisis deleted the feature/algoila branch March 23, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: docs Improvements or additions to documentation p: 2-high Fix main branch s: accepted Accepted feature / Confirmed bug

4 participants

@prisis @Shinigami92 @ST-DDT @griest024