fix: fix unique method types#457
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #457 +/- ##
==========================================
- Coverage 99.33% 99.33% -0.01%
==========================================
Files 1920 1920
Lines 174378 174323 -55
Branches 896 896
==========================================
- Hits 173219 173163 -56
- Misses 1103 1104 +1
Partials 56 56
|
Closed
Shinigami92
reviewed
Feb 9, 2022
Member
|
Did you see #333 ? |
Member
Author
|
No, i didn't see it (or forgot about it). |
b41fb61 to
2279c0b
Compare
2279c0b to
baaba6d
Compare
Shinigami92
approved these changes
Feb 10, 2022
prisis
approved these changes
Feb 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #456
Note: There is a slight imprecision I couldn't remove.
It is possible to omit the parameters, although the referenced method requires them.
If I fix that, it is no longer possible to omit the empty parameter array.