fix: datatype.datetime should use static boundaries

[ST-DDT]

Fixes #334

new Date().setFullYear(...) does not return a consistent value, as the actual time is not fixed an thus depends on the execution time + timezone.

This PR uses UTC based static values instead.

[pkuczynski]

Nice catch and fix! We use new Date() in date.te too, and I think I have seen some test failing around the midnight where the local time zone was the next day vs utc. Maybe it would be worth to apply it over there too?

[Shinigami92]

Oh my god (╯°□°)╯︵ ┻━┻

[ST-DDT]

Nice catch and fix! We use new Date() in date.te too, and I think I have seen some test failing around the midnight where the local time zone was the next day vs utc. Maybe it would be worth to apply it over there too?

The date module uses either new Date() with refers to a relative date or uses the dateRef parameter.
So it should be stable. If you catch a failing test, please report it so that we can analyze it and check only the related methods.

[ST-DDT]

This needs to be rebased after #344 is merged.

[ST-DDT]

Rebased

[codecov]

Codecov Report

Merging #343 (ee342c8) into main (301a6d2) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
- Coverage   99.33%   99.33%   -0.01%     
==========================================
  Files        1923     1923              
  Lines      176860   176860              
  Branches      917      915       -2     
==========================================
- Hits       175692   175690       -2     
- Misses       1112     1114       +2     
  Partials       56       56              

Impacted Files	Coverage Δ
src/datatype.ts	99.66% <100.00%> (ø)
src/vendor/unique.ts	93.54% <0.00%> (-1.62%)	⬇️

[pkuczynski]

Thats what I mentioned the other day. Cool that you fixed it :)