fix(food): use arrayElement instead of fake for adjective#3178
Merged
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3178 +/- ##
==========================================
+ Coverage 99.95% 99.97% +0.01%
==========================================
Files 2798 2798
Lines 227806 227808 +2
Branches 951 957 +6
==========================================
+ Hits 227708 227740 +32
+ Misses 98 68 -30
|
matthewmayer
approved these changes
Oct 13, 2024
ejcheng
approved these changes
Oct 13, 2024
Shinigami92
approved these changes
Oct 13, 2024
xDivisionByZerox
approved these changes
Oct 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The faker.food.adjective method incorrectly uses
faker.helpers.fakeinstead offaker.helpers.arrayElement.This PR fixes that.
Found while writing: #3176