Skip to content

fix(food): use arrayElement instead of fake for adjective#3178

Merged
xDivisionByZerox merged 2 commits into
nextfrom
fix/food/adjective/arrayElement
Oct 13, 2024
Merged

fix(food): use arrayElement instead of fake for adjective#3178
xDivisionByZerox merged 2 commits into
nextfrom
fix/food/adjective/arrayElement

Conversation

@ST-DDT

@ST-DDT ST-DDT commented Oct 12, 2024

Copy link
Copy Markdown
Member

The faker.food.adjective method incorrectly uses faker.helpers.fake instead of faker.helpers.arrayElement.
This PR fixes that.


Found while writing: #3176

@ST-DDT ST-DDT added c: bug Something isn't working p: 1-normal Nothing urgent m: food Something is referring to the food module labels Oct 12, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 12, 2024
@ST-DDT ST-DDT requested review from a team October 12, 2024 23:01
@ST-DDT ST-DDT self-assigned this Oct 12, 2024
@netlify

netlify Bot commented Oct 12, 2024

Copy link
Copy Markdown

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 3b0de6a
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/670bba5877579300086b70ab
😎 Deploy Preview https://deploy-preview-3178.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov

codecov Bot commented Oct 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (60c4865) to head (3b0de6a).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3178      +/-   ##
==========================================
+ Coverage   99.95%   99.97%   +0.01%     
==========================================
  Files        2798     2798              
  Lines      227806   227808       +2     
  Branches      951      957       +6     
==========================================
+ Hits       227708   227740      +32     
+ Misses         98       68      -30     
Files with missing lines Coverage Δ
src/modules/food/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@xDivisionByZerox xDivisionByZerox enabled auto-merge (squash) October 13, 2024 12:17
@xDivisionByZerox xDivisionByZerox merged commit a8dfa2f into next Oct 13, 2024
@xDivisionByZerox xDivisionByZerox deleted the fix/food/adjective/arrayElement branch October 13, 2024 12:20
@ST-DDT ST-DDT modified the milestones: vAnytime, v9.x Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: bug Something isn't working m: food Something is referring to the food module p: 1-normal Nothing urgent

5 participants