Skip to content

feat(locale): implement company info on pt_PT locale#3022

Merged
ST-DDT merged 2 commits into
faker-js:nextfrom
jeanpierrecarvalho:jpcarvalho/feat/implement-legal-entities-and-name-patterns-on-pt-pt
Aug 15, 2024
Merged

feat(locale): implement company info on pt_PT locale#3022
ST-DDT merged 2 commits into
faker-js:nextfrom
jeanpierrecarvalho:jpcarvalho/feat/implement-legal-entities-and-name-patterns-on-pt-pt

Conversation

@jeanpierrecarvalho

@jeanpierrecarvalho jeanpierrecarvalho commented Jul 16, 2024

Copy link
Copy Markdown
Contributor

Issue #3022: Implement Company Info on pt_PT Locale (Added Legal Entities and Name Patterns)

Changes Made:

  • Added Portuguese-specific legal entity types to the pt_PT locale.
  • Implemented new company name patterns to reflect common naming conventions in Portuguese.

Details of Changes:

  • Legal Entities:

    • Expanded the list of legal entity types to include Portuguese-specific entities such as EI, LDA, SA, SCR, and ULTDA.
    • Ensured each legal entity type is properly translated and accurately reflects its Portuguese equivalent.
  • Name Patterns:

    • Introduced new company name patterns that combine last names and legal entity types.
    • Ensured the use of the Portuguese conjunction 'e' for combining last names.

Additional Details:

  • These changes enhance the localization by ensuring that company information in the pt_PT locale is comprehensive and representative of real-world usage.
  • The updated data file now provides a more accurate and localized representation of company names and legal entities for Portuguese users.
@jeanpierrecarvalho jeanpierrecarvalho requested a review from a team as a code owner July 16, 2024 09:14
@netlify

netlify Bot commented Jul 16, 2024

Copy link
Copy Markdown

Deploy Preview for fakerjs canceled.

Name Link
🔨 Latest commit c2aa492
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66be799754ece000082d250d
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: company Something is referring to the company module labels Jul 16, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Jul 16, 2024
@ST-DDT ST-DDT requested review from a team July 16, 2024 11:31
@codecov

codecov Bot commented Jul 16, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (a210619) to head (c2aa492).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3022      +/-   ##
==========================================
- Coverage   99.96%   99.96%   -0.01%     
==========================================
  Files        2772     2775       +3     
  Lines      226221   226242      +21     
  Branches      939      591     -348     
==========================================
+ Hits       226153   226162       +9     
- Misses         68       80      +12     
Files Coverage Δ
src/locales/pt_PT/company/index.ts 100.00% <100.00%> (ø)
src/locales/pt_PT/company/legal_entity_type.ts 100.00% <100.00%> (ø)
src/locales/pt_PT/company/name_pattern.ts 100.00% <100.00%> (ø)
src/locales/pt_PT/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT changed the title feat: implement company info on pt_PT locale feat(locale): implement company info on pt_PT locale Jul 16, 2024
@ST-DDT ST-DDT enabled auto-merge (squash) August 15, 2024 21:57
@ST-DDT

ST-DDT commented Aug 15, 2024

Copy link
Copy Markdown
Member

Sorry for the long wait and thanks for your contribution ❤️

@ST-DDT ST-DDT merged commit 0fd0402 into faker-js:next Aug 15, 2024
@ST-DDT ST-DDT modified the milestones: vAnytime, v9.0 Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: locale Permutes locale definitions m: company Something is referring to the company module p: 1-normal Nothing urgent

3 participants