Skip to content

feat(internet): improve ipv4 method#2992

Merged
Shinigami92 merged 14 commits into
nextfrom
feat/internet/ipv4
Oct 10, 2024
Merged

feat(internet): improve ipv4 method#2992
Shinigami92 merged 14 commits into
nextfrom
feat/internet/ipv4

Conversation

@ST-DDT

@ST-DDT ST-DDT commented Jul 5, 2024

Copy link
Copy Markdown
Member

Improves the ipv4 generation options by adding parameters to configure the ip range to generate.

  • cidrBlock: Declares the explicit cidr range for the ip to generate in e.g. 192.168.42.0/24. Defaults to 0.0.0.0/0.
  • network: Alias for well known cidr-blocks such as loopback. Defaults to any.

Preview: internet#ipv4

grafik

Supersedes #2460

@ST-DDT ST-DDT added c: feature Request for new feature p: 1-normal Nothing urgent m: internet Something is referring to the internet module labels Jul 5, 2024
@ST-DDT ST-DDT added this to the v9.x milestone Jul 5, 2024
@ST-DDT ST-DDT requested review from a team July 5, 2024 14:30
@ST-DDT ST-DDT self-assigned this Jul 5, 2024
@netlify

netlify Bot commented Jul 5, 2024

Copy link
Copy Markdown

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 369f590
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/6707fc39a849800008652961
😎 Deploy Preview https://deploy-preview-2992.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov

codecov Bot commented Jul 5, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (5b1c858) to head (369f590).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2992   +/-   ##
=======================================
  Coverage   99.96%   99.97%           
=======================================
  Files        2796     2796           
  Lines      227441   227483   +42     
  Branches      955      957    +2     
=======================================
+ Hits       227366   227422   +56     
+ Misses         75       61   -14     
Files with missing lines Coverage Δ
src/index.ts 100.00% <ø> (ø)
src/modules/internet/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@xDivisionByZerox xDivisionByZerox left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly have a hard time understanding the implementation details, as I my only experience with bit manipulation is reading enum "flags" from an integer. I'm very happy for the test scenarios you provided.

Comment thread src/modules/internet/index.ts
Comment thread test/modules/internet.spec.ts
Comment thread src/modules/internet/index.ts Outdated
Comment thread src/modules/internet/index.ts Outdated
@ST-DDT ST-DDT added the s: needs decision Needs team/maintainer decision label Jul 15, 2024
@xDivisionByZerox xDivisionByZerox removed the s: needs decision Needs team/maintainer decision label Sep 5, 2024
@ST-DDT

ST-DDT commented Sep 27, 2024

Copy link
Copy Markdown
Member Author

Dear @ST-DDT, 😜

Thank you for your patience and contributions so far. We wanted to provide you with a brief update.

We are pleased to inform you that we have addressed all the known bugs in version 9.0. We will now take a short break and resume work around October 7, 2024, to begin merging new features for v9.1, including yours.

In the meantime, we hope you have a great time, and we sincerely appreciate your ongoing support and contributions.

Best regards,
your FakerJS Team

@xDivisionByZerox

Copy link
Copy Markdown
Member

Dear @ST-DDT, 😜

Thank you for your patience and contributions so far. We wanted to provide you with a brief update.

We are pleased to inform you that we have addressed all the known bugs in version 9.0. We will now take a short break and resume work around October 7, 2024, to begin merging new features for v9.1, including yours.

In the meantime, we hope you have a great time, and we sincerely appreciate your ongoing support and contributions.

Best regards, your FakerJS Team

obama-self-award-meme

LoL

@Shinigami92 Shinigami92 merged commit a5a6c5b into next Oct 10, 2024
@Shinigami92 Shinigami92 deleted the feat/internet/ipv4 branch October 10, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: feature Request for new feature m: internet Something is referring to the internet module p: 1-normal Nothing urgent

4 participants