feat(date)!: separate timeZone method#2947
Merged
Merged
Conversation
ST-DDT
added
c: feature
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2947 +/- ##
==========================================
- Coverage 99.96% 99.95% -0.01%
==========================================
Files 2987 2989 +2
Lines 216052 216099 +47
Branches 954 598 -356
==========================================
+ Hits 215973 216004 +31
- Misses 79 95 +16
|
ST-DDT
changed the title
ST-DDT
commented
Jun 12, 2024
ST-DDT
changed the title
Contributor
|
Why do you consider this breaking |
Member
Author
|
I'm not sure I do. It might not be ! Breaking but noteworthy for the migration guide nontheless. I think it could be considered breaking because it narrows the spec for location.timezone. |
matthewmayer
left a comment
matthewmayer
left a comment
Contributor
There was a problem hiding this comment.
Should we add a few time zones for a few "easy" locales just to check it works as expected?
Member
Author
IMO we can do that in one or more separate PRs. |
Shinigami92
previously approved these changes
Jun 13, 2024
Contributor
|
Could we add a test to check that all locale timezone definitions are subsets of the base list? |
ST-DDT
dismissed stale reviews from xDivisionByZerox and Shinigami92
via
082a882
Member
Author
Done |
xDivisionByZerox
previously approved these changes
Jun 18, 2024
Shinigami92
reviewed
Jun 18, 2024
xDivisionByZerox
approved these changes
Jun 20, 2024
Shinigami92
approved these changes
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds #735
Adds
faker.date.timeZone()for a random global time zone.Narrows
faker.location.timeZone()to a random locale specific time zone.