fix(person): add dedicated first names in ko locale

[qqww08]

Fixed an issue where Korean and English were mixed.
And we added the latest trend names for 2022 and 2023.

fakerKO.person.fullName(). // 위 Blake

[netlify]

✅ Deploy Preview for fakerjs canceled.

Name	Link
🔨 Latest commit	c80c59c
🔍 Latest deploy log	https://app.netlify.com/sites/fakerjs/deploys/6602c3e90fd0db0008a482ec

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (7f11bf2) to head (c80c59c).

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #2773      +/-   ##
==========================================
- Coverage   99.93%   99.92%   -0.01%     
==========================================
  Files        2958     2960       +2     
  Lines      213686   211338    -2348     
  Branches      946      943       -3     
==========================================
- Hits       213549   211188    -2361     
- Misses        133      146      +13     
  Partials        4        4              

Files	Coverage Δ
src/locales/ko/person/female_first_name.ts	100.00% <100.00%> (ø)
src/locales/ko/person/first_name.ts	100.00% <100.00%> (ø)
src/locales/ko/person/index.ts	100.00% <100.00%> (ø)
src/locales/ko/person/male_first_name.ts	100.00% <100.00%> (ø)
src/locales/ko/person/name.ts	100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

[ST-DDT]

Fixed an issue where Korean and English were mixed.

I didnt see any english names in the list.
Or do you refer to the ko translations of English names?
Or do you refer to the bug where firstName(sexType) return English names? #1677

And we added the latest trend names for 2022 and 2023.

This list seems to be significantly shorter than the previous one. Can we bump it to maybe a 100 each?

[qqww08]

@ST-DDT

There is no problem with firstName and lastName.

Try calling fakerKO.person.fullName()

I will update the list again with more names.

[matthewmayer]

Would it be better to change src/locales/ko/person/name.ts to remove the space between the family name and given name ie

{ value: '{{person.lastName}} {{person.firstName}}', weight: 1 },

to

{ value: '{{person.lastName}}{{person.firstName}}', weight: 1 },

per https://en.wikipedia.org/wiki/Korean_name "When a Korean name is written in Hangul, there is no space between the surname and the given name."

[qqww08]

@ST-DDT

This list seems to be significantly shorter than the previous one. Can we bump it to maybe a 100 each?

We have added the ranking of the most used names in Korea from 1st to 300th.
https://efamily.scourt.go.kr/index.jsp

I referred to Korean government statistics.

Would it be better to change src/locales/ko/person/name.ts to remove the space between the family name and given name ie
per https://en.wikipedia.org/wiki/Korean_name "When a Korean name is written in Hangul, there is no space between the surname and the given name."

That's right, in Korea there are no spaces in the name. This was reflected immediately.