Skip to content

refactor(location)!: remove default_country definitions#2740

Merged
Shinigami92 merged 4 commits into
faker-js:nextfrom
matthewmayer:rm-default-country
Mar 14, 2024
Merged

refactor(location)!: remove default_country definitions#2740
Shinigami92 merged 4 commits into
faker-js:nextfrom
matthewmayer:rm-default-country

Conversation

@matthewmayer

@matthewmayer matthewmayer commented Mar 12, 2024

Copy link
Copy Markdown
Contributor

Removes the old default_country definition files

@matthewmayer matthewmayer changed the title refactor(location): remove default_country definitions refactor(location)!: remove default_country definitions Mar 12, 2024
@matthewmayer matthewmayer self-assigned this Mar 12, 2024
@matthewmayer matthewmayer added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs c: locale Permutes locale definitions breaking change Cannot be merged when next version is not a major release m: location Something is referring to the location module labels Mar 12, 2024
@codecov

codecov Bot commented Mar 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.57%. Comparing base (5ef8ef1) to head (65a85de).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2740      +/-   ##
==========================================
+ Coverage   99.56%   99.57%   +0.01%     
==========================================
  Files        3034     2974      -60     
  Lines      250453   250273     -180     
  Branches      981      983       +2     
==========================================
- Hits       249367   249215     -152     
- Misses       1057     1058       +1     
+ Partials       29        0      -29     
Files Coverage Δ
src/locales/af_ZA/location/index.ts 100.00% <ø> (ø)
src/locales/ar/location/index.ts 100.00% <ø> (ø)
src/locales/az/location/index.ts 100.00% <ø> (ø)
src/locales/cs_CZ/location/index.ts 100.00% <ø> (ø)
src/locales/da/location/index.ts 100.00% <ø> (ø)
src/locales/de/location/index.ts 100.00% <ø> (ø)
src/locales/de_AT/location/index.ts 100.00% <ø> (ø)
src/locales/de_CH/location/index.ts 100.00% <ø> (ø)
src/locales/dv/location/index.ts 100.00% <ø> (ø)
src/locales/el/location/index.ts 100.00% <ø> (ø)
... and 50 more

... and 30 files with indirect coverage changes

@matthewmayer matthewmayer marked this pull request as ready for review March 12, 2024 14:45
@matthewmayer matthewmayer requested a review from a team as a code owner March 12, 2024 14:45
@ST-DDT ST-DDT added this to the v9.0 milestone Mar 12, 2024
@ST-DDT ST-DDT requested review from a team March 13, 2024 22:58
@Shinigami92 Shinigami92 merged commit a409b46 into faker-js:next Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Cannot be merged when next version is not a major release c: locale Permutes locale definitions c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: location Something is referring to the location module p: 1-normal Nothing urgent

4 participants