Skip to content

refactor(phone)!: remove v8 deprecated phone format#2712

Merged
ST-DDT merged 2 commits into
nextfrom
remove-deprecated-phone-format
Mar 5, 2024
Merged

refactor(phone)!: remove v8 deprecated phone format#2712
ST-DDT merged 2 commits into
nextfrom
remove-deprecated-phone-format

Conversation

@Shinigami92

Copy link
Copy Markdown
Member

No description provided.

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs breaking change Cannot be merged when next version is not a major release labels Mar 4, 2024
@Shinigami92 Shinigami92 added this to the v9.0 milestone Mar 4, 2024
@Shinigami92 Shinigami92 self-assigned this Mar 4, 2024
@Shinigami92 Shinigami92 requested a review from a team as a code owner March 4, 2024 13:19
@codecov

codecov Bot commented Mar 4, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.58%. Comparing base (e868060) to head (f16d1aa).

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #2712    +/-   ##
========================================
  Coverage   99.57%   99.58%            
========================================
  Files        2859     2859            
  Lines      248923   248878    -45     
  Branches      632      993   +361     
========================================
- Hits       247865   247833    -32     
+ Misses       1058     1045    -13     
Files Coverage Δ
src/modules/phone/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT requested review from a team March 4, 2024 14:33
@ST-DDT ST-DDT enabled auto-merge (squash) March 5, 2024 09:54
@ST-DDT ST-DDT added the m: phone Something is referring to the phone module label Mar 5, 2024
@ST-DDT ST-DDT merged commit 660da4c into next Mar 5, 2024
@ST-DDT ST-DDT deleted the remove-deprecated-phone-format branch March 5, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Cannot be merged when next version is not a major release c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: phone Something is referring to the phone module p: 1-normal Nothing urgent

3 participants