Skip to content

feat(helpers)!: use const generics where possible#2685

Merged
ST-DDT merged 6 commits into
nextfrom
feat/const/generics
Feb 25, 2024
Merged

feat(helpers)!: use const generics where possible#2685
ST-DDT merged 6 commits into
nextfrom
feat/const/generics

Conversation

@ST-DDT

@ST-DDT ST-DDT commented Feb 25, 2024

Copy link
Copy Markdown
Member

Implements #2679

This feature requires TS5+ and thus is a breaking change.

@ST-DDT ST-DDT added c: feature Request for new feature p: 1-normal Nothing urgent breaking change Cannot be merged when next version is not a major release labels Feb 25, 2024
@ST-DDT ST-DDT added this to the v9.0 milestone Feb 25, 2024
@ST-DDT ST-DDT self-assigned this Feb 25, 2024
@codecov

codecov Bot commented Feb 25, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.57%. Comparing base (64ff107) to head (5ab764d).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2685   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files        2815     2815           
  Lines      250300   250304    +4     
  Branches     1085     1086    +1     
=======================================
+ Hits       249238   249243    +5     
+ Misses       1062     1061    -1     
Files Coverage Δ
src/modules/helpers/index.ts 98.82% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

@Shinigami92

Copy link
Copy Markdown
Member

Should we add a https://vitest.dev/api/expect-typeof.html for this specific case?

@ST-DDT ST-DDT requested review from a team February 25, 2024 01:23
@ST-DDT ST-DDT marked this pull request as ready for review February 25, 2024 01:23
@ST-DDT

ST-DDT commented Feb 25, 2024

Copy link
Copy Markdown
Member Author

Should we add a vitest.dev/api/expect-typeof.html for this specific case?

I haven't used that feature yet, and I do not know whether/how to proceed regarding testing of this type only feature.

@ST-DDT ST-DDT linked an issue Feb 25, 2024 that may be closed by this pull request
@ST-DDT

ST-DDT commented Feb 25, 2024

Copy link
Copy Markdown
Member Author

Would you consider this ! breaking or not in the light of #1953?

This is a user facing change, but it technically isn't anymore breaking than using the new node features after updating to them.

Comment thread docs/guide/upgrading_v9/2685.md Outdated
@ST-DDT ST-DDT requested review from a team and matthewmayer February 25, 2024 13:31
@ST-DDT ST-DDT merged commit c45537f into next Feb 25, 2024
@ST-DDT ST-DDT deleted the feat/const/generics branch February 25, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Cannot be merged when next version is not a major release c: feature Request for new feature p: 1-normal Nothing urgent

4 participants