feat(helpers)!: use const generics where possible#2685
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2685 +/- ##
=======================================
Coverage 99.57% 99.57%
=======================================
Files 2815 2815
Lines 250300 250304 +4
Branches 1085 1086 +1
=======================================
+ Hits 249238 249243 +5
+ Misses 1062 1061 -1
|
Member
|
Should we add a https://vitest.dev/api/expect-typeof.html for this specific case? |
Member
Author
I haven't used that feature yet, and I do not know whether/how to proceed regarding testing of this type only feature. |
Member
Author
|
Would you consider this This is a user facing change, but it technically isn't anymore breaking than using the new node features after updating to them. |
matthewmayer
requested changes
Feb 25, 2024
Shinigami92
approved these changes
Feb 25, 2024
matthewmayer
approved these changes
Feb 25, 2024
ejcheng
approved these changes
Feb 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #2679
constmodifier on type parameters #2679This feature requires TS5+ and thus is a breaking change.