feat(locale): and location to fr_SN#2533
Merged
Merged
Conversation
…faker into add-locale-senegal
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2533 +/- ##
==========================================
- Coverage 99.58% 99.57% -0.01%
==========================================
Files 2787 2794 +7
Lines 249376 249473 +97
Branches 1084 1083 -1
==========================================
+ Hits 248333 248425 +92
- Misses 1015 1020 +5
Partials 28 28
|
ST-DDT
previously approved these changes
Nov 8, 2023
ST-DDT
added
p: 1-normal
matthewmayer
reviewed
Nov 8, 2023
matthewmayer
left a comment
matthewmayer
left a comment
Contributor
There was a problem hiding this comment.
How about location.state() does it make sense to use the regions for that?
https://en.wikipedia.org/wiki/Subdivisions_of_Senegal?wprov=sfti1#
Contributor
Author
|
Yes, that's a good idea, but should I remove them from the list of cities or not? |
Contributor
|
In other locales where state names happen to duplicate city names, we normally leave them in. |
ST-DDT
approved these changes
Nov 9, 2023
matthewmayer
approved these changes
Nov 10, 2023
matthewmayer
left a comment
matthewmayer
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Location module now seems well covered, could consider adding another PR with improved street names (otherwise will inherit from fr which might not be ideal).
Member
|
Thanks for your contribution ❤️ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I add the most popular cities in Senegal as well as the zip code format.
https://en.wikipedia.org/wiki/List_of_cities_in_Senegal