Skip to content

fix(location): Dutch postal codes can never start with '0'#2326

Merged
ST-DDT merged 3 commits into
faker-js:nextfrom
RobinvanderVliet:dutch-postal-codes
Aug 26, 2023
Merged

fix(location): Dutch postal codes can never start with '0'#2326
ST-DDT merged 3 commits into
faker-js:nextfrom
RobinvanderVliet:dutch-postal-codes

Conversation

@RobinvanderVliet

Copy link
Copy Markdown
Contributor

No description provided.

@RobinvanderVliet RobinvanderVliet requested a review from a team as a code owner August 20, 2023 15:36
@codecov

codecov Bot commented Aug 20, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2326 (a68af19) into next (3c839bf) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head a68af19 differs from pull request most recent head 88cfe0f. Consider uploading reports for the commit 88cfe0f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2326      +/-   ##
==========================================
- Coverage   99.60%   99.59%   -0.01%     
==========================================
  Files        2665     2665              
  Lines      246438   246448      +10     
  Branches     1086     1080       -6     
==========================================
- Hits       245468   245454      -14     
- Misses        943      967      +24     
  Partials       27       27              
Files Changed Coverage Δ
src/locales/nl/location/postcode.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module labels Aug 21, 2023
@ST-DDT

ST-DDT commented Aug 21, 2023

Copy link
Copy Markdown
Member

If you fix something please include a link that can be used for verification if possible.

@ST-DDT ST-DDT requested review from a team August 21, 2023 06:28
@ejcheng

ejcheng commented Aug 21, 2023

Copy link
Copy Markdown
Member

If you fix something please include a link that can be used for verification if possible.

Not too sure if this is good enough verification but it's what I found: https://stackoverflow.com/questions/17898523/regular-expression-for-dutch-zip-postal-code#:~:text=As%20an%20aside%3A%20Dutch%20postal%20codes%20never%20start%20with%20a%20zero.

@ST-DDT

ST-DDT commented Aug 21, 2023

Copy link
Copy Markdown
Member

If you fix something please include a link that can be used for verification if possible.

Not too sure if this is good enough verification but it's what I found: stackoverflow.com/questions/17898523/regular-expression-for-dutch-zip-postal-code#:~:text=As%20an%20aside%3A%20Dutch%20postal%20codes%20never%20start%20with%20a%20zero.

Well, there is always https://github.com/validatorjs/validator.js/blob/master/src/lib/isPostalCode.js

@matthewmayer

Copy link
Copy Markdown
Contributor
@ST-DDT ST-DDT enabled auto-merge (squash) August 26, 2023 11:46
@ST-DDT ST-DDT merged commit f195e06 into faker-js:next Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent

5 participants