feat(location): Support ISO 3166-1 numeric country codes

[RobinvanderVliet]

This merge request resolves issue #2302.

[codecov]

Codecov Report

Merging #2325 (7953272) into next (cb33664) will increase coverage by 0.00%.
The diff coverage is 99.64%.

Additional details and impacted files

@@           Coverage Diff           @@
##             next    #2325   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files        2793     2793           
  Lines      251568   251586   +18     
  Branches     1091     1097    +6     
=======================================
+ Hits       250572   250599   +27     
+ Misses        969      960    -9     
  Partials       27       27           

Files Changed	Coverage Δ
src/definitions/location.ts	0.00% <0.00%> (ø)
src/locales/base/location/country_code.ts	100.00% <100.00%> (ø)
src/locales/de_CH/location/country_code.ts	100.00% <100.00%> (ø)
src/locales/fr_CH/location/country_code.ts	100.00% <100.00%> (ø)
src/modules/location/index.ts	99.19% <100.00%> (+0.01%)	⬆️

... and 1 file with indirect coverage changes

[suhaibmujahid]

Thank you, @RobinvanderVliet! LGTM.

[ST-DDT]

There seems to be some issues with the new implementation.

[matthewmayer]

I don't think you can do that kind of object mapping in Typescript. Probably use the switch version.

[Shinigami92]

I don't think you can do that kind of object mapping in Typescript. Probably use the switch version.

No, just add the alpha2 case, and maybe also a as const

[matthewmayer]

i think the switch version is much nicer to read and makes it clear what the default is

const key = (() => {
     switch(variant) {
       case 'numeric': 
         return 'numeric';
       case 'alpha-3': 
         return 'alpha3';
       case 'alpha-2': 
       default: 
         return 'alpha2';
     }
   })();