Skip to content

feat(locale): Fully Improve zh_TW#2320

Merged
ST-DDT merged 10 commits into
faker-js:nextfrom
CoolPlayLin:improve_zh_TW
Aug 20, 2023
Merged

feat(locale): Fully Improve zh_TW#2320
ST-DDT merged 10 commits into
faker-js:nextfrom
CoolPlayLin:improve_zh_TW

Conversation

@CoolPlayLin

@CoolPlayLin CoolPlayLin commented Aug 15, 2023

Copy link
Copy Markdown
Contributor

Works

  • Add color module
  • Add date module
  • Fix according to ISO codes
@CoolPlayLin CoolPlayLin requested a review from a team as a code owner August 15, 2023 00:48
ST-DDT
ST-DDT previously approved these changes Aug 15, 2023
@ST-DDT ST-DDT added c: locale Permutes locale definitions m: color Something is referring to the color module m: date Something is referring to the date module p: 1-normal Nothing urgent labels Aug 15, 2023
@ST-DDT ST-DDT requested review from a team August 15, 2023 15:04
@codecov

codecov Bot commented Aug 15, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2320 (3b67a75) into next (c158b38) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 3b67a75 differs from pull request most recent head 6958c46. Consider uploading reports for the commit 6958c46 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2320      +/-   ##
==========================================
- Coverage   99.60%   99.60%   -0.01%     
==========================================
  Files        2660     2649      -11     
  Lines      246345   245706     -639     
  Branches     1086     1086              
==========================================
- Hits       245375   244729     -646     
- Misses        943      950       +7     
  Partials       27       27              
Files Changed Coverage Δ
src/locales/zh_TW/color/human.ts 100.00% <100.00%> (ø)
src/locales/zh_TW/color/index.ts 100.00% <100.00%> (ø)
src/locales/zh_TW/date/index.ts 100.00% <100.00%> (ø)
src/locales/zh_TW/date/month.ts 100.00% <100.00%> (ø)
src/locales/zh_TW/date/weekday.ts 100.00% <100.00%> (ø)
src/locales/zh_TW/index.ts 100.00% <100.00%> (ø)

... and 20 files with indirect coverage changes

@ST-DDT

ST-DDT commented Aug 15, 2023

Copy link
Copy Markdown
Member

Please run pnpm run preflight.

@CoolPlayLin CoolPlayLin reopened this Aug 16, 2023
@CoolPlayLin CoolPlayLin removed their assignment Aug 16, 2023
@ST-DDT ST-DDT requested a review from a team August 16, 2023 15:45
Comment thread src/locales/zh_TW/location/default_country.ts Outdated
@CoolPlayLin CoolPlayLin requested a review from ST-DDT August 17, 2023 23:59
@CoolPlayLin

CoolPlayLin commented Aug 19, 2023

Copy link
Copy Markdown
Contributor Author

@Shinigami92 @xDivisionByZerox @import-brain Could you review this for me? Thanks a lot!

@matthewmayer

Copy link
Copy Markdown
Contributor

It is quite normal that PRs in the Faker project can take weeks to get reviewed and merged even if they are 100% fine.

You don't need to do anything, the maintainers will notify you if any changes are needed.

@ST-DDT

ST-DDT commented Aug 19, 2023

Copy link
Copy Markdown
Member

It is quite normal that PRs in the Faker project can take weeks to get reviewed and merged even if they are 100% fine.

I wouldnt limit this to Faker or OpenSource specifically. It is just a mater of available time and priorities.

@ST-DDT ST-DDT enabled auto-merge (squash) August 20, 2023 06:41
@ST-DDT ST-DDT merged commit c5dfe27 into faker-js:next Aug 20, 2023
@ST-DDT

ST-DDT commented Aug 20, 2023

Copy link
Copy Markdown
Member

Thanks for your contribution. ❤️

@CoolPlayLin CoolPlayLin deleted the improve_zh_TW branch August 20, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: locale Permutes locale definitions m: color Something is referring to the color module m: date Something is referring to the date module p: 1-normal Nothing urgent

4 participants