Skip to content

feat(helpers): new method objectEntry#2123

Merged
ST-DDT merged 4 commits into
faker-js:nextfrom
suyashgulati:helper-object-entry-method
May 3, 2023
Merged

feat(helpers): new method objectEntry#2123
ST-DDT merged 4 commits into
faker-js:nextfrom
suyashgulati:helper-object-entry-method

Conversation

@suyashgulati

@suyashgulati suyashgulati commented May 3, 2023

Copy link
Copy Markdown
Contributor

For issue #1764, added a new helper method named faker.helpers.objectEntry that will return a random key-value pair from the given object.

Changes made:

  • Added a new method faker.helpers.objectEntry
  • Added tests and updated snapshots
@suyashgulati suyashgulati requested a review from a team as a code owner May 3, 2023 11:35
Comment thread src/modules/helpers/index.ts
Comment thread src/modules/helpers/index.ts Outdated
Comment thread src/modules/helpers/index.ts Outdated
Comment thread src/modules/helpers/index.ts Outdated
Comment thread test/helpers.spec.ts Outdated
Comment thread test/helpers.spec.ts Outdated
Comment thread test/helpers.spec.ts Outdated
@matthewmayer matthewmayer changed the title feat(helpers): Added new helper method 'ObjectEntry' feat(helpers): Added new helper method 'objectEntry' May 3, 2023
@codecov

codecov Bot commented May 3, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2123 (a66826a) into next (ede6ffa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2123   +/-   ##
=======================================
  Coverage   99.58%   99.59%           
=======================================
  Files        2605     2605           
  Lines      244944   244969   +25     
  Branches     1250     1249    -1     
=======================================
+ Hits       243939   243968   +29     
+ Misses        978      974    -4     
  Partials       27       27           
Impacted Files Coverage Δ
src/modules/helpers/index.ts 99.09% <100.00%> (+0.01%) ⬆️

... and 2 files with indirect coverage changes

@suyashgulati suyashgulati requested a review from matthewmayer May 3, 2023 12:02
@Shinigami92 Shinigami92 added c: feature Request for new feature p: 1-normal Nothing urgent m: helpers Something is referring to the helpers module labels May 3, 2023
@suyashgulati

Copy link
Copy Markdown
Contributor Author

@Shinigami92 Can you also assign issue #1764 to me as well.

@Shinigami92 Shinigami92 linked an issue May 3, 2023 that may be closed by this pull request
@Shinigami92

Copy link
Copy Markdown
Member

@Shinigami92 Can you also assign issue #1764 to me as well.

github doesn't let me select you, maybe you need to write a comment there

Comment thread src/modules/helpers/index.ts Outdated
Comment thread src/modules/helpers/index.ts Outdated
@Shinigami92 Shinigami92 changed the title feat(helpers): Added new helper method 'objectEntry' feat(helpers): new method objectEntry May 3, 2023
@ST-DDT ST-DDT merged commit c092aa1 into faker-js:next May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: feature Request for new feature m: helpers Something is referring to the helpers module p: 1-normal Nothing urgent

5 participants