fix(internet): fix invalid emails in some locales#1746
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1746 +/- ##
==========================================
+ Coverage 99.63% 99.64% +0.01%
==========================================
Files 2337 2337
Lines 242582 242589 +7
Branches 1098 1103 +5
==========================================
+ Hits 241698 241737 +39
+ Misses 863 831 -32
Partials 21 21
|
ST-DDT
reviewed
Jan 17, 2023
Member
|
FFR: This fixes only one of two problems in #1739 . |
ST-DDT
added
c: bug
Contributor
Author
do you have an example of an invalid email address which is still generated? |
Contributor
Author
ah looks like that was the problem in |
matthewmayer
changed the title
Member
|
Can you also add a filter that removes all invalid characters from the local part, so it still generates a valid email even if the given name/firstname are invalid? Please also add a test for both too long names and invalid characters. |
ST-DDT
previously approved these changes
Jan 18, 2023
ejcheng
previously approved these changes
Jan 18, 2023
ST-DDT
approved these changes
Jan 19, 2023
xDivisionByZerox
approved these changes
Jan 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1739