Skip to content

feat(locales): add mergeLocales utility#1707

Merged
ST-DDT merged 13 commits into
nextfrom
feat/locales/merge
Jan 13, 2023
Merged

feat(locales): add mergeLocales utility#1707
ST-DDT merged 13 commits into
nextfrom
feat/locales/merge

Conversation

@ST-DDT

@ST-DDT ST-DDT commented Jan 2, 2023

Copy link
Copy Markdown
Member

Part 1 of

This PR provides a method that merges multiple locales into a single one.

Future PRs will:

@ST-DDT ST-DDT added c: feature Request for new feature p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug c: locale Permutes locale definitions labels Jan 2, 2023
@ST-DDT ST-DDT added this to the v8.0 - Module Re-Shuffling milestone Jan 2, 2023
@ST-DDT ST-DDT requested review from a team January 2, 2023 01:25
@ST-DDT ST-DDT self-assigned this Jan 2, 2023
Comment thread src/utils/merge-locales.ts
Comment thread src/utils/merge-locales.ts Outdated
@codecov

codecov Bot commented Jan 2, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1707 (1dd8e63) into next (47b2cfc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1707   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2336     2337    +1     
  Lines      241141   241178   +37     
  Branches     1088     1098   +10     
=======================================
+ Hits       240257   240294   +37     
  Misses        863      863           
  Partials       21       21           
Impacted Files Coverage Δ
src/utils/merge-locales.ts 100.00% <100.00%> (ø)
Comment thread src/utils/merge-locales.ts Outdated
Comment thread src/utils/merge-locales.ts Outdated
Comment thread src/utils/merge-locales.ts Outdated
Comment thread src/utils/merge-locales.ts
Comment thread test/utils/merge-locales.spec.ts
@ST-DDT ST-DDT requested a review from Shinigami92 January 2, 2023 21:55
Comment thread test/utils/merge-locales.spec.ts
@ST-DDT ST-DDT requested review from a team January 6, 2023 09:59
@ST-DDT ST-DDT requested a review from a team January 11, 2023 18:48
Comment thread src/utils/merge-locales.ts Outdated
Comment thread test/utils/merge-locales.spec.ts
Comment thread src/utils/merge-locales.ts Outdated
@ST-DDT ST-DDT requested review from a team and Shinigami92 January 11, 2023 21:35
@ST-DDT ST-DDT merged commit 788fce0 into next Jan 13, 2023
@ST-DDT ST-DDT deleted the feat/locales/merge branch January 13, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: feature Request for new feature c: locale Permutes locale definitions p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug

3 participants