fix(location): use IANA standard for timezone#1678
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1678 +/- ##
==========================================
- Coverage 99.64% 99.64% -0.01%
==========================================
Files 2244 2240 -4
Lines 240509 240286 -223
Branches 1072 1072
==========================================
- Hits 239650 239427 -223
Misses 838 838
Partials 21 21
|
ST-DDT
approved these changes
Dec 21, 2022
ejcheng
approved these changes
Dec 21, 2022
Shinigami92
approved these changes
Dec 23, 2022
Shinigami92
left a comment
Member
There was a problem hiding this comment.
For now this is okay, but in #735 we need to move it out of en into a global thingy
Member
I was questioning if I should mark that in this PR. @matthewmayer do you want to do that as well? Otherwise I could do that, should be easy enough. |
Contributor
Author
|
maybe locales might want to override this in future? Like en_AU could return only Australian timezones |
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #734
I generated this using a library which already parses the official tzdb data and therefore contains all valid tz names.
I also deleted the list from other locales except
ensince these were just duplicates of the global list (in theoryanother locale might want to have its own list, e.g. en_AU could return only Australian timestamps?)