Skip to content

feat(number)!: change float default params#1642

Merged
ST-DDT merged 7 commits into
nextfrom
1597-change-numberfloat-default-value-from-precision-to-max
Dec 9, 2022
Merged

feat(number)!: change float default params#1642
ST-DDT merged 7 commits into
nextfrom
1597-change-numberfloat-default-value-from-precision-to-max

Conversation

@Shinigami92

@Shinigami92 Shinigami92 commented Dec 7, 2022

Copy link
Copy Markdown
Member

closes #1597
@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: number Something is referring to the number module labels Dec 7, 2022
@Shinigami92 Shinigami92 added this to the v8.0 - Module Re-Shuffling milestone Dec 7, 2022
@Shinigami92 Shinigami92 self-assigned this Dec 7, 2022
@codecov

codecov Bot commented Dec 7, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1642 (2faef56) into next (6baa8ce) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #1642      +/-   ##
==========================================
+ Coverage   99.62%   99.63%   +0.01%     
==========================================
  Files        2222     2222              
  Lines      240500   240507       +7     
  Branches     1066     1072       +6     
==========================================
+ Hits       239598   239630      +32     
+ Misses        881      856      -25     
  Partials       21       21
Impacted Files Coverage Δ
src/modules/color/index.ts 99.73% <100.00%> (ø)
src/modules/datatype/index.ts 100.00% <100.00%> (ø)
src/modules/helpers/index.ts 98.61% <100.00%> (-0.01%) ⬇️
src/modules/number/index.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 90.81% <0.00%> (+6.75%) ⬆️
@Shinigami92 Shinigami92 marked this pull request as ready for review December 7, 2022 21:37
@Shinigami92 Shinigami92 requested a review from a team as a code owner December 7, 2022 21:37
@Shinigami92 Shinigami92 requested a review from a team December 7, 2022 21:37
ST-DDT
ST-DDT reviewed Dec 8, 2022
View reviewed changes
Comment thread test/number.spec.ts Outdated
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Dec 8, 2022
@Shinigami92 Shinigami92 requested a review from ST-DDT December 8, 2022 07:57
ST-DDT
ST-DDT previously approved these changes Dec 8, 2022
View reviewed changes
ejcheng
ejcheng previously approved these changes Dec 8, 2022
View reviewed changes
@Shinigami92 Shinigami92 requested review from a team December 8, 2022 20:38
xDivisionByZerox
xDivisionByZerox reviewed Dec 8, 2022
View reviewed changes
Comment thread src/modules/number/index.ts Outdated
@Shinigami92 Shinigami92 dismissed stale reviews from ejcheng and ST-DDT via 2faef56 December 8, 2022 21:03
@Shinigami92 @xDivisionByZerox
Update src/modules/number/index.ts
2faef56 
Co-authored-by: Leyla Jähnig <leyla.jaehnig@gmx.de>
xDivisionByZerox
xDivisionByZerox reviewed Dec 8, 2022
View reviewed changes
Comment thread test/__snapshots__/number.spec.ts.snap
@ST-DDT ST-DDT merged commit 671631b into next Dec 9, 2022
@ST-DDT ST-DDT deleted the 1597-change-numberfloat-default-value-from-precision-to-max branch December 9, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: number Something is referring to the number module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug

4 participants

@Shinigami92 @ST-DDT @ejcheng @xDivisionByZerox