refactor!: cleanup deprecations

[Shinigami92]

closes #1439

[codecov]

Codecov Report

Merging #1440 (fc9b9c8) into next (1ab33c5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #1440      +/-   ##
==========================================
- Coverage   99.62%   99.61%   -0.02%     
==========================================
  Files        2166     2164       -2     
  Lines      237450   236816     -634     
  Branches     1044     1001      -43     
==========================================
- Hits       236567   235898     -669     
- Misses        862      896      +34     
- Partials       21       22       +1     

Impacted Files	Coverage Δ
src/modules/commerce/index.ts	100.00% <ø> (ø)
src/modules/helpers/index.ts	98.44% <ø> (-0.07%)	⬇️
src/modules/image/providers/lorempicsum.ts	93.85% <ø> (-1.00%)	⬇️
src/modules/image/providers/lorempixel.ts	91.30% <ø> (-0.65%)	⬇️
src/modules/image/providers/unsplash.ts	100.00% <ø> (+4.67%)	⬆️
src/modules/phone/index.ts	100.00% <ø> (ø)
src/faker.ts	100.00% <100.00%> (ø)
src/index.ts	100.00% <100.00%> (ø)
src/modules/address/index.ts	99.78% <100.00%> (-0.05%)	⬇️
src/modules/company/index.ts	100.00% <100.00%> (ø)
... and 7 more

[xDivisionByZerox]

How do we handle this as it is marked for removal in v8.0?

faker/src/modules/address/index.ts

Lines 137 to 152 in 2914a69

	streetName(): string {
	if (this.faker.definitions.address.street_name == null) {
	deprecated({
	deprecated:
	'faker.address.streetName() without address.street_name definitions',
	proposed:
	'faker.address.street() or provide address.street_name definitions',
	since: '7.0',
	until: '8.0',
	});
	return this.street();
	}
	return this.faker.helpers.arrayElement(
	this.faker.definitions.address.street_name
	);
	}

[xDivisionByZerox]

You missed this on:

faker/src/modules/datatype/index.ts

Lines 220 to 235 in 2914a69

	hexadecimal(
	options:
	| { length?: number; prefix?: string; case?: 'lower' | 'upper' | 'mixed' }
	| number = {}
	): string {
	if (typeof options === 'number') {
	deprecated({
	deprecated: 'faker.datatype.hexadecimal(length)',
	proposed: 'faker.datatype.hexadecimal({ length })',
	since: '7.5',
	until: '8.0',
	});
	options = {
	length: options,
	};
	}

[ejcheng]

You missed this on:

faker/src/modules/datatype/index.ts

Lines 220 to 235 in 2914a69

	hexadecimal(
	options:
	| { length?: number; prefix?: string; case?: 'lower' | 'upper' | 'mixed' }
	| number = {}
	): string {
	if (typeof options === 'number') {
	deprecated({
	deprecated: 'faker.datatype.hexadecimal(length)',
	proposed: 'faker.datatype.hexadecimal({ length })',
	since: '7.5',
	until: '8.0',
	});
	options = {
	length: options,
	};
	}

Good catch.

[Shinigami92]

@xDivisionByZerox nice catch!
I also found streetName 👍