Skip to content

feat(locale): add new Indonesia state#1400

Merged
Shinigami92 merged 3 commits into
faker-js:mainfrom
fzn0x:patch-3
Sep 29, 2022
Merged

feat(locale): add new Indonesia state#1400
Shinigami92 merged 3 commits into
faker-js:mainfrom
fzn0x:patch-3

Conversation

@fzn0x

@fzn0x fzn0x commented Sep 27, 2022

Copy link
Copy Markdown
Contributor

Papua Tengah: Prove of existence is our Constitution UU No. 15 Tahun 2022
Papua Pegunungan: Prove of existence is our Constitution UU No. 16 Tahun 2022
Papua Selatan: Prove of existence is our Constitution UU No. 14 Tahun 2022

We get and we have new state 🎉

Papua Tengah: UU No. 15 Tahun 2022
Papua Pegunungan: UU No. 16 Tahun 2022
Papua Selatan: UU No. 14 Tahun 2022

We get and we have new state 🎉
@fzn0x fzn0x requested a review from a team as a code owner September 27, 2022 11:34

@ST-DDT ST-DDT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified using the German Wikipedia:
https://de.wikipedia.org/wiki/Indonesien#Administrative_Gliederung

The English Wikipedia does not mention this yet.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug c: locale Permutes locale definitions labels Sep 27, 2022
@ST-DDT ST-DDT added this to the v7 - Current Major milestone Sep 27, 2022
@ST-DDT ST-DDT requested review from a team September 27, 2022 16:17
@codecov

codecov Bot commented Sep 27, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1400 (c5298ab) into main (7abeae5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c5298ab differs from pull request most recent head e4afe1c. Consider uploading reports for the commit e4afe1c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1400   +/-   ##
=======================================
  Coverage   99.62%   99.63%           
=======================================
  Files        2163     2163           
  Lines      241303   241306    +3     
  Branches     1017     1021    +4     
=======================================
+ Hits       240396   240423   +27     
+ Misses        886      862   -24     
  Partials       21       21           
Impacted Files Coverage Δ
src/locales/id_ID/address/state.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 88.09% <0.00%> (+6.34%) ⬆️
@ST-DDT ST-DDT added the m: location Something is referring to the location module label Sep 27, 2022
@Shinigami92 Shinigami92 changed the title feat(id_ID): add new Indonesia state feat(locale): add new Indonesia state Sep 29, 2022
@Shinigami92 Shinigami92 enabled auto-merge (squash) September 29, 2022 14:18
@Shinigami92 Shinigami92 merged commit be87581 into faker-js:main Sep 29, 2022
@fzn0x fzn0x deleted the patch-3 branch September 29, 2022 17:25
wael-fadlallah pushed a commit to wael-fadlallah/faker that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug

6 participants