Skip to content

fix(finance): fix typo in Belarusian Ruble's name#1395

Merged
ST-DDT merged 1 commit into
faker-js:mainfrom
AdriVanHoudt:patch-4
Sep 26, 2022
Merged

fix(finance): fix typo in Belarusian Ruble's name#1395
ST-DDT merged 1 commit into
faker-js:mainfrom
AdriVanHoudt:patch-4

Conversation

@AdriVanHoudt

@AdriVanHoudt AdriVanHoudt commented Sep 26, 2022

Copy link
Copy Markdown
Contributor
@AdriVanHoudt AdriVanHoudt requested a review from a team as a code owner September 26, 2022 15:45
@AdriVanHoudt AdriVanHoudt mentioned this pull request Sep 26, 2022
Merged
ST-DDT
ST-DDT previously approved these changes Sep 26, 2022
View reviewed changes
@ST-DDT ST-DDT added c: locale Permutes locale definitions p: 1-normal Nothing urgent m: finance Something is referring to the finance module labels Sep 26, 2022
@ST-DDT ST-DDT added this to the v7 - Current Major milestone Sep 26, 2022
@ST-DDT ST-DDT requested review from a team September 26, 2022 16:26
@ST-DDT ST-DDT added s: accepted Accepted feature / Confirmed bug needs rebase There is a merge conflict labels Sep 26, 2022
@ST-DDT

ST-DDT commented Sep 26, 2022

Copy link
Copy Markdown
Member

This needs a rebase.
@codecov

codecov Bot commented Sep 26, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1395 (220b573) into main (526906f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1395   +/-   ##
=======================================
  Coverage   99.62%   99.63%           
=======================================
  Files        2163     2163           
  Lines      241303   241303           
  Branches     1014     1017    +3     
=======================================
+ Hits       240403   240420   +17     
+ Misses        879      862   -17     
  Partials       21       21
Impacted Files Coverage Δ
src/locales/en/finance/currency.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 88.09% <0.00%> (+4.49%) ⬆️
@AdriVanHoudt

AdriVanHoudt commented Sep 26, 2022

Copy link
Copy Markdown
Contributor Author

Rebased
@ST-DDT ST-DDT requested a review from a team September 26, 2022 16:55
@xDivisionByZerox xDivisionByZerox removed the needs rebase There is a merge conflict label Sep 26, 2022
@ST-DDT ST-DDT merged commit fe214c3 into faker-js:main Sep 26, 2022
@AdriVanHoudt AdriVanHoudt deleted the patch-4 branch September 27, 2022 06:50
wael-fadlallah pushed a commit to wael-fadlallah/faker that referenced this pull request Oct 14, 2022
@AdriVanHoudt @wael-fadlallah
fix(finance): fix typo in Belarusian Ruble's name (faker-js#1395)
a0b2934
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: locale Permutes locale definitions m: finance Something is referring to the finance module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug

4 participants

@AdriVanHoudt @ST-DDT @ejcheng @xDivisionByZerox