Skip to content

fix(finance): adjust min length of generated bitcoin address#1384

Merged
Shinigami92 merged 2 commits into
faker-js:mainfrom
Minozzzi:fix/finance/bitcoinAddress
Sep 22, 2022
Merged

fix(finance): adjust min length of generated bitcoin address#1384
Shinigami92 merged 2 commits into
faker-js:mainfrom
Minozzzi:fix/finance/bitcoinAddress

Conversation

@Minozzzi

Copy link
Copy Markdown
Contributor

No description provided.

@Minozzzi Minozzzi requested a review from a team as a code owner September 22, 2022 17:00
@codecov

codecov Bot commented Sep 22, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1384 (4ad7467) into main (fe97c29) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1384      +/-   ##
==========================================
- Coverage   99.62%   99.62%   -0.01%     
==========================================
  Files        2163     2163              
  Lines      241275   241275              
  Branches     1015     1013       -2     
==========================================
- Hits       240371   240368       -3     
- Misses        883      886       +3     
  Partials       21       21              
Impacted Files Coverage Δ
src/modules/finance/index.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 81.74% <0.00%> (-0.80%) ⬇️
@ejcheng ejcheng added c: bug Something isn't working m: finance Something is referring to the finance module labels Sep 22, 2022
@ejcheng ejcheng added this to the v7 - Current Major milestone Sep 22, 2022
@ejcheng ejcheng requested a review from a team September 22, 2022 17:06
@Shinigami92 Shinigami92 changed the title fix(finance/bitcoinAddress): fixes the minimum quantity of the generated address fix(finance): adjust min length of generated bitcoin address Sep 22, 2022
@Shinigami92 Shinigami92 enabled auto-merge (squash) September 22, 2022 17:07
@Shinigami92 Shinigami92 merged commit 10aded2 into faker-js:main Sep 22, 2022
wael-fadlallah pushed a commit to wael-fadlallah/faker that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: bug Something isn't working m: finance Something is referring to the finance module

4 participants