Skip to content

feat(locale): add first name for zh_CN#1376

Merged
Shinigami92 merged 3 commits into
faker-js:mainfrom
kaysonwu:main
Sep 29, 2022
Merged

feat(locale): add first name for zh_CN#1376
Shinigami92 merged 3 commits into
faker-js:mainfrom
kaysonwu:main

Conversation

@kaysonwu

@kaysonwu kaysonwu commented Sep 15, 2022

Copy link
Copy Markdown
Contributor

add female_first_name and male_first_name for zh_CN
@kaysonwu kaysonwu requested a review from a team as a code owner September 15, 2022 07:28
@kaysonwu kaysonwu closed this Sep 15, 2022
@kaysonwu kaysonwu changed the title add first name for zh_CN chore: add first name for zh_CN Sep 15, 2022
@kaysonwu kaysonwu reopened this Sep 15, 2022
@codecov

codecov Bot commented Sep 15, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1376 (4ab4acf) into main (0bbcb7f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1376      +/-   ##
==========================================
+ Coverage   99.62%   99.63%   +0.01%     
==========================================
  Files        2163     2165       +2     
  Lines      241306   241432     +126     
  Branches     1017     1021       +4     
==========================================
+ Hits       240399   240549     +150     
+ Misses        886      862      -24     
  Partials       21       21
Impacted Files Coverage Δ
src/locales/zh_CN/name/female_first_name.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/name/index.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/name/male_first_name.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 88.09% <0.00%> (+6.34%) ⬆️
@Shinigami92 Shinigami92 requested a review from ejcheng September 15, 2022 19:52
@Shinigami92 Shinigami92 added the c: locale Permutes locale definitions label Sep 15, 2022
@Shinigami92 Shinigami92 added this to the v7 - Current Major milestone Sep 15, 2022
@Shinigami92

Shinigami92 commented Sep 15, 2022

Copy link
Copy Markdown
Member

Please run pnpm run format once
ejcheng
ejcheng previously approved these changes Sep 15, 2022
View reviewed changes
@ejcheng

ejcheng commented Sep 15, 2022

Copy link
Copy Markdown
Member

Names are legit👌
ST-DDT
ST-DDT requested changes Sep 26, 2022
View reviewed changes

@ST-DDT ST-DDT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run pnpm run format or should we do that for you?
@Shinigami92 Shinigami92 changed the title chore: add first name for zh_CN feat(locale): add first name for zh_CN Sep 29, 2022
@Shinigami92 Shinigami92 enabled auto-merge (squash) September 29, 2022 15:00
@Shinigami92 Shinigami92 requested a review from ST-DDT September 29, 2022 15:00
@Shinigami92 Shinigami92 merged commit 1d8ea82 into faker-js:main Sep 29, 2022
wael-fadlallah pushed a commit to wael-fadlallah/faker that referenced this pull request Oct 14, 2022
@kaysonwu @wael-fadlallah
feat(locale): add first name for zh_CN (faker-js#1376)
0889993
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: locale Permutes locale definitions

4 participants

@kaysonwu @Shinigami92 @ejcheng @ST-DDT