Skip to content

fix(internal): Fix typo in deprecation message#1316

Merged
Shinigami92 merged 1 commit into
mainfrom
fix/deprecated-typo
Aug 29, 2022
Merged

fix(internal): Fix typo in deprecation message#1316
Shinigami92 merged 1 commit into
mainfrom
fix/deprecated-typo

Conversation

@ST-DDT

@ST-DDT ST-DDT commented Aug 29, 2022

Copy link
Copy Markdown
Member

Remove duplicate dot at EOL.

- [@faker-js/faker]: faker.image.lorempicsum.avatar() is deprecated since v7.3 and will be removed in v8.0. Please use faker.internet.avatar() instead..
+ [@faker-js/faker]: faker.image.lorempicsum.avatar() is deprecated since v7.3 and will be removed in v8.0. Please use faker.internet.avatar() instead.
@ST-DDT ST-DDT added c: bug Something isn't working p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Aug 29, 2022
@ST-DDT ST-DDT added this to the v7 - Current Major milestone Aug 29, 2022
@ST-DDT ST-DDT requested review from a team August 29, 2022 14:22
@ST-DDT ST-DDT self-assigned this Aug 29, 2022
@codecov

codecov Bot commented Aug 29, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1316 (0bfc3d4) into main (8fecd58) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1316   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files        2160     2160           
  Lines      240614   240614           
  Branches     1014     1014           
=======================================
  Hits       239707   239707           
  Misses        886      886           
  Partials       21       21           
Impacted Files Coverage Δ
src/internal/deprecated.ts 100.00% <100.00%> (ø)
@Shinigami92 Shinigami92 merged commit 7b18404 into main Aug 29, 2022
@Shinigami92 Shinigami92 deleted the fix/deprecated-typo branch August 29, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: bug Something isn't working p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug

3 participants