cleanup rn_ama_new_arch_ios.bridge_batch_did_complete_fix (#50598)

Summary:
Pull Request resolved: #50598

changelog: [ios][breaking] delete BridgeModuleBatchDidComplete config helpers

this is not used anywhere, cleanup

Reviewed By: srinathvijay

Differential Revision: D72692359

fbshipit-source-id: 42220a64be59bc0d32efe76c1f1d8fc4508a6b0e

Author: philIip

packages/react-native/React/Base/RCTBridge.h

@@ -82,9 +82,6 @@ void RCTSetTurboModuleInteropBridgeProxyLogLevel(RCTBridgeProxyLoggingLevel logL
 BOOL RCTTurboModuleInteropForAllTurboModulesEnabled(void);
 void RCTEnableTurboModuleInteropForAllTurboModules(BOOL enabled);
 
-BOOL RCTBridgeModuleBatchDidCompleteDisabled(void);
-void RCTDisableBridgeModuleBatchDidComplete(BOOL disabled);
-
 typedef enum {
   kRCTGlobalScope,
   kRCTGlobalScopeUsingRetainJSCallback,

packages/react-native/React/Base/RCTBridge.mm

@@ -254,17 +254,6 @@ void RCTEnableTurboModuleSyncVoidMethods(BOOL enabled)
   gTurboModuleEnableSyncVoidMethods = enabled;
 }
 
-static BOOL gBridgeModuleDisableBatchDidComplete = NO;
-BOOL RCTBridgeModuleBatchDidCompleteDisabled(void)
-{
-  return gBridgeModuleDisableBatchDidComplete;
-}
-
-void RCTDisableBridgeModuleBatchDidComplete(BOOL disabled)
-{
-  gBridgeModuleDisableBatchDidComplete = disabled;
-}
-
 BOOL kDispatchAccessibilityManagerInitOntoMain = NO;
 BOOL RCTUIManagerDispatchAccessibilityManagerInitOntoMain(void)
 {

packages/react-native/React/CxxBridge/RCTCxxBridge.mm

@@ -1458,27 +1458,15 @@ - (void)registerSegmentWithId:(NSUInteger)segmentId path:(NSString *)path
 
 - (void)batchDidComplete
 {
-  if (RCTBridgeModuleBatchDidCompleteDisabled()) {
-    id uiManager = [self moduleForName:@"UIManager"];
-    if ([uiManager respondsToSelector:@selector(batchDidComplete)] &&
-        [uiManager respondsToSelector:@selector(methodQueue)]) {
+  // TODO #12592471: batchDidComplete is only used by RCTUIManager,
+  // can we eliminate this special case?
+  for (RCTModuleData *moduleData in _moduleDataByID) {
+    if (moduleData.implementsBatchDidComplete) {
       [self
           dispatchBlock:^{
-            [uiManager batchDidComplete];
+            [moduleData.instance batchDidComplete];
           }
-                  queue:[uiManager methodQueue]];
-    }
-  } else {
-    // TODO #12592471: batchDidComplete is only used by RCTUIManager,
-    // can we eliminate this special case?
-    for (RCTModuleData *moduleData in _moduleDataByID) {
-      if (moduleData.implementsBatchDidComplete) {
-        [self
-            dispatchBlock:^{
-              [moduleData.instance batchDidComplete];
-            }
-                    queue:moduleData.methodQueue];
-      }
+                  queue:moduleData.methodQueue];
     }
   }
 }