Migrate to Kotlin - DevSupportManagerBase.kt (#50559)

Summary:
Pull Request resolved: #50559

This diff migrates the following file to Kotlin - DevSupportManagerBase.kt
as part of our ongoing effort of migrating the codebase to Kotlin

This file was 1000LOC+ so its migration is quite involved.
I had to look into nullability of various parameters. Most notably the `Array<StackFrame?>` -> `Array<StackFrame>`.

This also is the last file left in the devsupport package that needs to be migrated to Kotlin.

Changelog:
[Android] [Breaking] - DevSupportManagerBase is now converted to Kotlin. If you're subclassing this class, you will have to adjust some of the parameters as types have changed during the migration.

Reviewed By: javache, mdvacca

Differential Revision: D72637098

fbshipit-source-id: b87d5f17e30d69fe9c09ec9b49f96818df34ea3b

Author: cortinico

packages/react-native/ReactAndroid/api/ReactAndroid.api

@@ -1996,35 +1996,35 @@ public abstract interface class com/facebook/react/devsupport/DevServerHelper$Pa
 }
 
 public abstract class com/facebook/react/devsupport/DevSupportManagerBase : com/facebook/react/devsupport/interfaces/DevSupportManager {
-	protected final field mReactInstanceDevHelper Lcom/facebook/react/devsupport/ReactInstanceDevHelper;
+	public static final field Companion Lcom/facebook/react/devsupport/DevSupportManagerBase$Companion;
 	public fun <init> (Landroid/content/Context;Lcom/facebook/react/devsupport/ReactInstanceDevHelper;Ljava/lang/String;ZLcom/facebook/react/devsupport/interfaces/RedBoxHandler;Lcom/facebook/react/devsupport/interfaces/DevBundleDownloadListener;ILjava/util/Map;Lcom/facebook/react/common/SurfaceDelegateFactory;Lcom/facebook/react/devsupport/interfaces/DevLoadingViewManager;Lcom/facebook/react/devsupport/interfaces/PausedInDebuggerOverlayManager;)V
 	public fun addCustomDevOption (Ljava/lang/String;Lcom/facebook/react/devsupport/interfaces/DevOptionHandler;)V
 	public fun createRootView (Ljava/lang/String;)Landroid/view/View;
 	public fun createSurfaceDelegate (Ljava/lang/String;)Lcom/facebook/react/common/SurfaceDelegate;
 	public fun destroyRootView (Landroid/view/View;)V
 	public fun downloadBundleResourceFromUrlSync (Ljava/lang/String;Ljava/io/File;)Ljava/io/File;
-	public fun fetchSplitBundleAndCreateBundleLoader (Ljava/lang/String;Lcom/facebook/react/devsupport/DevSupportManagerBase$CallbackWithBundleLoader;)V
-	protected fun getApplicationContext ()Landroid/content/Context;
+	public final fun fetchSplitBundleAndCreateBundleLoader (Ljava/lang/String;Lcom/facebook/react/devsupport/DevSupportManagerBase$CallbackWithBundleLoader;)V
+	protected final fun getApplicationContext ()Landroid/content/Context;
 	public fun getCurrentActivity ()Landroid/app/Activity;
-	public fun getCurrentReactContext ()Lcom/facebook/react/bridge/ReactContext;
-	public fun getDevLoadingViewManager ()Lcom/facebook/react/devsupport/interfaces/DevLoadingViewManager;
-	public fun getDevServerHelper ()Lcom/facebook/react/devsupport/DevServerHelper;
-	public fun getDevSettings ()Lcom/facebook/react/modules/debug/interfaces/DeveloperSettings;
-	public fun getDevSupportEnabled ()Z
+	public final fun getCurrentReactContext ()Lcom/facebook/react/bridge/ReactContext;
+	public final fun getDevLoadingViewManager ()Lcom/facebook/react/devsupport/interfaces/DevLoadingViewManager;
+	public final fun getDevServerHelper ()Lcom/facebook/react/devsupport/DevServerHelper;
+	public final fun getDevSettings ()Lcom/facebook/react/modules/debug/interfaces/DeveloperSettings;
+	public final fun getDevSupportEnabled ()Z
 	public fun getDownloadedJSBundleFile ()Ljava/lang/String;
-	public fun getJSAppBundleName ()Ljava/lang/String;
-	public fun getLastErrorCookie ()I
-	public fun getLastErrorStack ()[Lcom/facebook/react/devsupport/interfaces/StackFrame;
-	public fun getLastErrorTitle ()Ljava/lang/String;
-	public fun getLastErrorType ()Lcom/facebook/react/devsupport/interfaces/ErrorType;
-	public fun getReactInstanceDevHelper ()Lcom/facebook/react/devsupport/ReactInstanceDevHelper;
+	public final fun getJSAppBundleName ()Ljava/lang/String;
+	public final fun getLastErrorCookie ()I
+	public final fun getLastErrorStack ()[Lcom/facebook/react/devsupport/interfaces/StackFrame;
+	public final fun getLastErrorTitle ()Ljava/lang/String;
+	public final fun getLastErrorType ()Lcom/facebook/react/devsupport/interfaces/ErrorType;
+	public final fun getReactInstanceDevHelper ()Lcom/facebook/react/devsupport/ReactInstanceDevHelper;
 	public fun getRedBoxHandler ()Lcom/facebook/react/devsupport/interfaces/RedBoxHandler;
 	public fun getSourceMapUrl ()Ljava/lang/String;
 	public fun getSourceUrl ()Ljava/lang/String;
 	protected abstract fun getUniqueTag ()Ljava/lang/String;
 	public fun handleException (Ljava/lang/Exception;)V
 	public fun hasUpToDateJSBundleInCache ()Z
-	protected fun hideDevLoadingView ()V
+	protected final fun hideDevLoadingView ()V
 	public fun hidePausedInDebuggerOverlay ()V
 	public fun hideRedboxDialog ()V
 	public fun isPackagerRunning (Lcom/facebook/react/devsupport/interfaces/PackagerStatusCallback;)V
@@ -2036,11 +2036,16 @@ public abstract class com/facebook/react/devsupport/DevSupportManagerBase : com/
 	public fun reloadJSFromServer (Ljava/lang/String;Lcom/facebook/react/devsupport/interfaces/BundleLoadCallback;)V
 	public fun reloadSettings ()V
 	public fun setAdditionalOptionForPackager (Ljava/lang/String;Ljava/lang/String;)V
-	public fun setDevSupportEnabled (Z)V
+	public final fun setDevLoadingViewManager (Lcom/facebook/react/devsupport/interfaces/DevLoadingViewManager;)V
+	public final fun setDevSupportEnabled (Z)V
 	public fun setFpsDebugEnabled (Z)V
 	public fun setHotModuleReplacementEnabled (Z)V
+	public final fun setLastErrorCookie (I)V
+	public final fun setLastErrorStack ([Lcom/facebook/react/devsupport/interfaces/StackFrame;)V
+	public final fun setLastErrorTitle (Ljava/lang/String;)V
+	public final fun setLastErrorType (Lcom/facebook/react/devsupport/interfaces/ErrorType;)V
 	public fun setPackagerLocationCustomizer (Lcom/facebook/react/devsupport/interfaces/DevSupportManager$PackagerLocationCustomizer;)V
-	protected fun showDevLoadingViewForRemoteJSEnabled ()V
+	protected final fun showDevLoadingViewForRemoteJSEnabled ()V
 	public fun showDevOptionsDialog ()V
 	public fun showNewJSError (Ljava/lang/String;Lcom/facebook/react/bridge/ReadableArray;I)V
 	public fun showNewJavaError (Ljava/lang/String;Ljava/lang/Throwable;)V
@@ -2055,6 +2060,9 @@ public abstract interface class com/facebook/react/devsupport/DevSupportManagerB
 	public abstract fun onSuccess (Lcom/facebook/react/bridge/JSBundleLoader;)V
 }
 
+public final class com/facebook/react/devsupport/DevSupportManagerBase$Companion {
+}
+
 public abstract interface class com/facebook/react/devsupport/DevSupportManagerFactory {
 	public abstract fun create (Landroid/content/Context;Lcom/facebook/react/devsupport/ReactInstanceDevHelper;Ljava/lang/String;ZLcom/facebook/react/devsupport/interfaces/RedBoxHandler;Lcom/facebook/react/devsupport/interfaces/DevBundleDownloadListener;ILjava/util/Map;Lcom/facebook/react/common/SurfaceDelegateFactory;Lcom/facebook/react/devsupport/interfaces/DevLoadingViewManager;Lcom/facebook/react/devsupport/interfaces/PausedInDebuggerOverlayManager;)Lcom/facebook/react/devsupport/interfaces/DevSupportManager;
 	public abstract fun create (Landroid/content/Context;Lcom/facebook/react/devsupport/ReactInstanceDevHelper;Ljava/lang/String;ZLcom/facebook/react/devsupport/interfaces/RedBoxHandler;Lcom/facebook/react/devsupport/interfaces/DevBundleDownloadListener;ILjava/util/Map;Lcom/facebook/react/common/SurfaceDelegateFactory;Lcom/facebook/react/devsupport/interfaces/DevLoadingViewManager;Lcom/facebook/react/devsupport/interfaces/PausedInDebuggerOverlayManager;Z)Lcom/facebook/react/devsupport/interfaces/DevSupportManager;

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/BridgeDevSupportManager.kt

@@ -56,7 +56,7 @@ public class BridgeDevSupportManager(
     redBoxHandler: RedBoxHandler?,
     devBundleDownloadListener: DevBundleDownloadListener?,
     minNumShakes: Int,
-    customPackagerCommandHandlers: Map<String?, RequestHandler?>?,
+    customPackagerCommandHandlers: Map<String, RequestHandler>?,
     surfaceDelegateFactory: SurfaceDelegateFactory?,
     devLoadingViewManager: DevLoadingViewManager?,
     pausedInDebuggerOverlayManager: PausedInDebuggerOverlayManager?
@@ -74,7 +74,8 @@ public class BridgeDevSupportManager(
         devLoadingViewManager,
         pausedInDebuggerOverlayManager) {
 
-  override fun getUniqueTag(): String = "Bridge"
+  override val uniqueTag: String
+    get() = "Bridge"
 
   override fun loadSplitBundleFromServer(bundlePath: String, callback: DevSplitBundleCallback) {
     fetchSplitBundleAndCreateBundleLoader(

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/BridgelessDevSupportManager.kt

@@ -71,17 +71,18 @@ internal class BridgelessDevSupportManager(
       devLoadingViewManager = null,
       pausedInDebuggerOverlayManager = null)
 
-  override fun getUniqueTag(): String = "Bridgeless"
+  override val uniqueTag: String
+    get() = "Bridgeless"
 
   override fun loadSplitBundleFromServer(bundlePath: String, callback: DevSplitBundleCallback) {
     fetchSplitBundleAndCreateBundleLoader(
         bundlePath,
         object : CallbackWithBundleLoader {
           override fun onSuccess(bundleLoader: JSBundleLoader) {
             try {
-              mReactInstanceDevHelper.loadBundle(bundleLoader).waitForCompletion()
+              reactInstanceDevHelper.loadBundle(bundleLoader).waitForCompletion()
               val bundleURL = devServerHelper.getDevServerSplitBundleURL(bundlePath)
-              val reactContext = mReactInstanceDevHelper.currentReactContext
+              val reactContext = reactInstanceDevHelper.currentReactContext
               reactContext?.getJSModule(HMRClient::class.java)?.registerBundle(bundleURL)
               callback.onSuccess()
             } catch (e: InterruptedException) {
@@ -99,6 +100,6 @@ internal class BridgelessDevSupportManager(
     UiThreadUtil.assertOnUiThread()
     // dismiss redbox if exists
     hideRedboxDialog()
-    mReactInstanceDevHelper.reload("BridgelessDevSupportManager.handleReloadJS()")
+    reactInstanceDevHelper.reload("BridgelessDevSupportManager.handleReloadJS()")
   }
 }