feat: add support for Import Attributes and RegExp Modifiers - #639
Conversation
nzakas
left a comment
There was a problem hiding this comment.
LGTM. Waiting for another approval before merging.
mdjermanovic
left a comment
There was a problem hiding this comment.
Are there any changes to eslint-scope needed?
If not, can you just add a few tests to confirm? For example:
const type = "json";
import pkg from "./package.json" with { type: "json" }; // not a reference to `type`
export * from "./package.json" with { type: "json" }; // not a reference to `type`
export { default } from "./package.json" with { type: "json" }; // not a reference to `type`
import("./package.json", { with: { type } }); // a reference to `type`|
Thank you for the review! |
|
I added test cases to eslint-scope. |
Yeah, I double-checked the code.
For |
Prerequisites checklist
What is the purpose of this pull request?
Add support for ES2025 import attributes, and add support for RegExp modifiers.
What changes did you make? (Give an overview)
This PR adds support for ES2025 import attributes and RegExp modifiers.
Related Issues
Related to eslint/eslint#19014, eslint/eslint#19073
Is there anything you'd like reviewers to focus on?