Skip to content

Bump notary version to 0.4.2#27074

Merged
vdemeester merged 2 commits into
moby:masterfrom
cyli:bump-notary-version
Oct 17, 2016
Merged

Bump notary version to 0.4.2#27074
vdemeester merged 2 commits into
moby:masterfrom
cyli:bump-notary-version

Conversation

@cyli
Copy link
Copy Markdown
Contributor

@cyli cyli commented Sep 30, 2016 •
edited
Loading

This bumps the notary dependency up to 0.4.2 (full changelogs here).

The docker-client-relevant behavior changes are:

  • Will now compile under windows #970
  • Improved error messages for client authentication errors #972
  • Support for finding keys that are anywhere in the ~/.docker/trust/private directory, not just under ~/.docker/trust/private/root_keys or ``~/.docker/trust/private/tuf_keys` #981
  • Previously, on any error updating, the client would fall back on the cache. Now we only do so if there is a network error or if the server is unavailable or missing the TUF data. Invalid TUF data will cause the update to fail - for example if there was an invalid root rotation. #982
  • Improve root validation and yubikey debug logging #858 #891
  • Warn if certificates for root or delegations are near expiry #802
  • Warn if role metadata is near expiry #786
  • Fix passphrase retrieval attempt counting and terminal detection #906

cc @riyazdf @endophage
@cyli cyli changed the title Bump notary version to 0.4.1 Bump notary version to 0.4.2 Oct 1, 2016
@vieux
Copy link
Copy Markdown
Contributor

vieux commented Oct 5, 2016

ping @riyazdf @endophage
@vieux
Copy link
Copy Markdown
Contributor

vieux commented Oct 5, 2016

SGTM
@endophage
Copy link
Copy Markdown
Contributor

endophage commented Oct 5, 2016

LGTM!
@cyli
Copy link
Copy Markdown
Contributor Author

cyli commented Oct 5, 2016

^sorry, fixed an error message typo in two of the tests
@justincormack
Copy link
Copy Markdown
Contributor

justincormack commented Oct 11, 2016

LGTM
1 similar comment
@riyazdf
Copy link
Copy Markdown
Contributor

riyazdf commented Oct 11, 2016

LGTM
@cyli
Copy link
Copy Markdown
Contributor Author

cyli commented Oct 13, 2016

bump. :) can this be merged?
@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Oct 15, 2016

Looks like some related commits could be squashed, or are we good with having them all separate?
@cyli
Copy link
Copy Markdown
Contributor Author

cyli commented Oct 15, 2016

@thaJeztah I have no strong feelings. I can squash them if you like.
cyli added 2 commits October 14, 2016 17:52
@cyli
Bump vendored and dockerfile notary version to v0.4.2
5f4dcd8 
Signed-off-by: cyli <cyli@twistedmatrix.com>
@cyli
Fix API incompatibilities between notary v0.3.0 and v0.4.2:
0797af3 
- some function signatures have changed - use the new ones
- re-generate the notary delegation key certs, since notary doesn't allow SHA1
- fix some error message mapping because now if a root rotation fails to validate trusted operations will fail

Signed-off-by: cyli <cyli@twistedmatrix.com>
@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Oct 15, 2016

@cyli perhaps split in "bump" commits and "fix" commits
@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Oct 15, 2016

oh! done already, haha
thaJeztah
thaJeztah approved these changes Oct 15, 2016
View reviewed changes
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@vdemeester vdemeester merged commit a7c883f into moby:master Oct 17, 2016
@thaJeztah thaJeztah added this to the 1.13.0 milestone Oct 17, 2016
dnephin pushed a commit to dnephin/docker that referenced this pull request Apr 17, 2017
@vdemeester
Merge pull request moby#27074 from cyli/bump-notary-version
6566662 
Bump notary version to 0.4.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment