Vendor libnetwork v0.7.0-dev.2#20214
Conversation
|
LGTM |
|
test this please |
- Expose EnableIPV6 option - discoverapi refactoring - Fixed a few typos & docs update - Fixes moby#20140 Signed-off-by: Madhu Venugopal <madhu@docker.com>
9d5b56a to
b2e6091
Compare
|
LGTM |
|
|
||
| #get libnetwork packages | ||
| clone git github.com/docker/libnetwork v0.6.1-rc2 | ||
| clone git github.com/docker/libnetwork v0.7.0-dev.2 |
There was a problem hiding this comment.
is this 0.7 bump expected?
There was a problem hiding this comment.
Yes. It's our dev branch in libnetwork which aligns with docker master for 1.11
There was a problem hiding this comment.
So you confirm it's not diverging from the 1.10 branch ?
There was a problem hiding this comment.
to be clear. everything in libnetwork 0.7.x is meant for 1.11 and not for 1.10 release branch.
After this commit, anything specific to 1.10 must go into the bump release branch (1.10.1).
There was a problem hiding this comment.
So if we merge this, this won't be in 1.10.1. Correct?
There was a problem hiding this comment.
correct. I will push a individual patch in 1.10.1 that fixes #20140 alone. Since it is a P3 and not specific to 1.10 (it was seen also in 1.9), we can decide to pick it up or not, based on priority and release requirements.
|
LGTM |
docker network inspect#17513)Signed-off-by: Madhu Venugopal madhu@docker.com