rename convert to config to align with compose v1 UX
#10214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 73.89% // Head: 73.89% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## v2 #10214 +/- ##
=======================================
Coverage 73.89% 73.89%
=======================================
Files 2 2
Lines 272 272
=======================================
Hits 201 201
Misses 60 60
Partials 11 11 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ndeloof
requested review from
a team,
StefanScherer,
glours,
laurazard,
milas,
nicksieger and
ulyssessouza
and removed request for
a team
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
convert_config
branch
from
b695ece to
b723790
Compare
laurazard
approved these changes
Jan 30, 2023
milas
approved these changes
Jan 30, 2023
matt9ucci
added a commit
to matt9ucci/DockerCompletion
that referenced
this pull request
Feb 9, 2023
matt9ucci
added a commit
to matt9ucci/DockerCompletion
that referenced
this pull request
Feb 9, 2023
matt9ucci
added a commit
to matt9ucci/DockerCompletion
that referenced
this pull request
Feb 9, 2023
matt9ucci
added a commit
to matt9ucci/DockerCompletion
that referenced
this pull request
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
renamed "convert" command to "config" to be aligned with Compose V1 UX
convertwas introduced by Cloud integration development as we translated the compose model into cloud provider custom format. It was later adopted as the basis forcompose configimplementation, but changing the command canonical name doesn't make sense for our users (thousands blogs, stackoverflow, ... mention use ofconfigcommand)