imagetools inspect: keep platform order #972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
imagetools-inspect-order
branch
from
8e42996 to
ab73630
Compare
tonistiigi
reviewed
Mar 4, 2022
Member
tonistiigi
left a comment
tonistiigi
left a comment
There was a problem hiding this comment.
As discussed offline, the added lines are not worth it. Let's just keep it deterministic. JSON is already sorted, just update the printBuildInfos to also do the alphabetical sort.
crazy-max
force-pushed
the
imagetools-inspect-order
branch
from
ab73630 to
9218714
Compare
tonistiigi
reviewed
Mar 4, 2022
crazy-max
force-pushed
the
imagetools-inspect-order
branch
2 times, most recently
from
ec5bdc8 to
198808a
Compare
tonistiigi
reviewed
Mar 4, 2022
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
imagetools-inspect-order
branch
from
198808a to
215a128
Compare
tonistiigi
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up #854
keep order from the manifest and also print formatted image config.