Get multi-platform buildkit frontend opt from args #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy83
force-pushed
the
deterministic_output
branch
from
993267b to
c823fcb
Compare
Member
|
if you want to set the frontend opt you should do it directly. |
tonistiigi
changed the title
Member
|
nit while you fix the rest: typo in commit title |
This allows builders to opt into determnistic output regardless of multi-platform output or not. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
deterministic_output
branch
from
c823fcb to
7f58ad4
Compare
tonistiigi
approved these changes
Dec 8, 2020
Member
|
@cpuguy83 I think we should add this into the Dockerfile frontend as well. Otherwise, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows builders to opt into determnistic output regardless of
multi-platform output or not.
This resolves the real intention behind 158; deterministic output.
Closes #158