detect moby worker supports multiplatform feature through containerd snapshotter #1260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…snapshotter Signed-off-by: Nicolas De Loof <[email protected]>
crazy-max
reviewed
Aug 9, 2022
| if err == nil { | ||
| workers, _ := c.ListWorkers(ctx) | ||
| for _, w := range workers { | ||
| if _, ok := w.Labels["org.mobyproject.buildkit.worker.snapshotter"]; ok { |
Member
There was a problem hiding this comment.
Could you use LabelSnapshotter instead: https://github.com/moby/buildkit/blob/86c33b66e176a6fc74b88d6f46798d3ec18e2e73/worker/worker.go#L50
Otherwise LGTM
Member
There was a problem hiding this comment.
I think this is in a package we don't currently import
Member
There was a problem hiding this comment.
Ah yes and this one imports quite a lot.
Contributor
Author
There was a problem hiding this comment.
I tried to, but adding buildkit/vendor import require me to run make vendor and this brings a crazy amount of changes
Member
There was a problem hiding this comment.
@ndeloof Yes let's keep it like this in the meantime
tonistiigi
approved these changes
Aug 9, 2022
crazy-max
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.