Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cncf-tags/container-device-interface
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: cncf-tags/container-device-interface
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: release/0.8
Choose a head ref
  • 4 commits
  • 2 files changed
  • 2 contributors

Commits on Feb 24, 2025

  1. pkg/cdi: add test case for EMFILE crash (avoidance). 

    Signed-off-by: Krisztian Litkey <[email protected]>
    @klihub
    klihub committed Feb 24, 2025
    Configuration menu
    Copy the full SHA
    66aa9a8 View commit details
    Browse the repository at this point in the history

  2. pkg/cdi: don't crash if we fail to create fsnotify watch. 

    Don't crash in update() if we fail to create an fsnotify watch.
This can happen if we have too many open files. In this case we
now record a failure for all configured spec directories and in
update we always trigger a refresh. If the process if ever able
to create new file descriptors the cache becomes functional but
in a 'always implicitly fully refreshed' mode instead of auto-
refreshed.

It's not entirely clear what is the best option to deal with a
failed watch creation. Being out of file descriptors typically
results in a cascading chain of errors which the process does
not usually survive.

This fix aims for minimal footprint. On failed watch creation
it does not render the cache fully unusable. If the process is
ever able to create new file descriptors again the cache also
becomes functional, but instead of autorefreshed mode it will
be in an 'always implicitly fully refreshed' mode.

Signed-off-by: Krisztian Litkey <[email protected]>
    @klihub
    klihub committed Feb 24, 2025
    Configuration menu
    Copy the full SHA
    d0ccbf8 View commit details
    Browse the repository at this point in the history

  3. pkg/cdi: add test case for post-EMFILE recovery. 

    Test that the cache indeed recovers functionally if the process
ever recovers from not being able to create new file descriptors.

Signed-off-by: Krisztian Litkey <[email protected]>
    @klihub
    klihub committed Feb 24, 2025
    Configuration menu
    Copy the full SHA
    693c957 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #255 from klihub/fixes/release-0.8/refresh-sigsegv… 

    …-with-nil-watcher

[release/0.8] don't crash in cache refresh/update with nil fsnotify watcher.
    @bart0sh
    bart0sh authored Feb 24, 2025
    Configuration menu
    Copy the full SHA
    d1a2c36 View commit details
    Browse the repository at this point in the history
Loading