Filter out enumerable from JS completion candidates

Fixes #39

Author: rrudakov

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## master
 
+- [#39](https://github.com/clojure-emacs/clj-suitable/issues/39): Exclude enumerable from JS completion candidates.
+
 ## 0.5.1 (2023-10-31)
 
 - [#41](https://github.com/clojure-emacs/clj-suitable/pull/41): Expand completion for non-namespaced keywords.

src/main/suitable/js_introspection.cljs

@@ -28,6 +28,7 @@
      (for [[i {:keys [_obj props]}] (map-indexed vector (properties-by-prototype js-obj))
            key (js-keys props)
            :when (and (not (get @seen key))
+                      (not (oget (oget props key) "enumerable"))
                       (or (empty? prefix)
                           (starts-with? key prefix)))]
        (let [prop (oget props key)]

src/test/suitable/complete_for_nrepl_test.clj

@@ -2,9 +2,9 @@
   (:require
    [cider.piggieback :as piggieback]
    [clojure.java.shell]
-   [clojure.test :as t :refer [deftest is run-tests testing]]
+   [clojure.test :as t :refer [are deftest is run-tests testing]]
    [nrepl.core :as nrepl]
-   [nrepl.server :refer [start-server default-handler]]
+   [nrepl.server :refer [default-handler start-server]]
    [suitable.complete-for-nrepl :as sut]
    [suitable.middleware :refer [wrap-complete-standalone]]))
 
@@ -103,7 +103,20 @@
                                :context ":same"})
             candidates (:completions response)]
         (is (= [{:ns "js/Object", :candidate ".keys" :type "function"}] candidates)
-            (pr-str response))))))
+            (pr-str response))))
+
+    (testing "make sure that enumerable items are filtered out"
+      (are [context candidates] (= candidates
+                                   (let [response   (message {:op      "complete"
+                                                              :ns      "cljs.user"
+                                                              :symbol  ".-"
+                                                              :context context})]
+                                     (:completions response)))
+        "(__prefix__ (js/String \"abc\"))"
+        [{:candidate ".-length", :ns "(js/String \"abc\")", :type "var"}]
+
+        "(-> (js/String \"abc\") __prefix__)"
+        [{:candidate ".-length", :ns "(-> (js/String \"abc\"))", :type "var"}]))))
 
 (deftest node-env?
   (is (false? (sut/node-env? nil)))