Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: callstack/react-native-builder-bob
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: [email protected]
Choose a base ref
...
head repository: callstack/react-native-builder-bob
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
  • 7 commits
  • 8 files changed
  • 6 contributors

Commits on Jun 17, 2025

  1. docs: update link

    thymikee authored Jun 17, 2025
    Configuration menu
    Copy the full SHA
    2233957 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2025

  1. fix(template): Add missing configutation for nitro-modules (#862)

    ### Summary
    While creating a nitro-module using `npx
    create-react-native-library@latest` and debugging issues I ran to, I
    [noticed](mrousavy/nitro#696 (comment))
    there are missing configurations in the podspec.
    
    Mainly the following was missing when building a nitro-module:
    
    ```ruby
      s.source_files = [
        # Implementation (Swift)
        "ios/**/*.{swift}",
        # Autolinking/Registration (Objective-C++)
        "ios/**/*.{m,mm}",
        # Implementation (C++ objects)
        "cpp/**/*.{hpp,cpp}",
      ]
    
      s.pod_target_xcconfig = {
        # C++ compiler flags, mainly for folly.
        "GCC_PREPROCESSOR_DEFINITIONS" => "$(inherited) FOLLY_NO_CONFIG FOLLY_CFG_NO_COROUTINES"
      }
    
      s.dependency 'React-jsi'
      s.dependency 'React-callinvoker'
      ```
    
    This fixes the compilation errors around not finding Folly, or the module not compiling.
    
    ### Test plan
    
    I tested this locally by running the tool and having the correct generated file.
    
    ---------
    
    Co-authored-by: Satyajit Sahoo <[email protected]>
    serjooo and satya164 authored Jun 21, 2025
    Configuration menu
    Copy the full SHA
    fe58737 View commit details
    Browse the repository at this point in the history
  2. chore: remove invalid render property from bug report template (#863)

    ## summary
    Fix bug report issue template not displaying properly due to invalid
    `render: js` property.
    - Removed invalid `render: js` property from bug report template
    - Issue template now displays correctly in GitHub Issues interface
    
    
    #### before
    <img width="722" alt="image"
    src="https://github.com/user-attachments/assets/a29acf28-a1c0-4d17-9a97-777b4370b0fb"
    />
    
    #### after
    
    <img width="421" alt="image"
    src="https://github.com/user-attachments/assets/9f360b78-2f69-4bdc-acac-c32413dd1a10"
    />
    
    
    #### reference
    -
    https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema#input
    
    <!-- What existing problem does the pull request solve? Can you solve
    the issue with a different approach? -->
    
    
    ### Test plan
    
    <!-- List the steps with which we can test this change. Provide
    screenshots if this changes anything visual. -->
    saseungmin authored Jun 21, 2025
    Configuration menu
    Copy the full SHA
    7597dd7 View commit details
    Browse the repository at this point in the history
  3. fix(template): remove the view manager template for iOS (#864)

    <!-- Please provide enough information so that others can review your
    pull request. -->
    <!-- Keep pull requests small and focused on a single change. -->
    
    ### Summary
    
    Currently, with React Native versions `0.79.x` to `0.80.x`, the
    definition of `Fabric View` components has been changed. You can find
    that there is no `ViewManager` in the React Native documentation:
    https://reactnative.dev/docs/next/fabric-native-components-introduction
    
    Additionaly, `RCTViewManager` could lead to the problem with
    registration:
    <img width="299" alt="image"
    src="https://github.com/user-attachments/assets/d6035ff7-0536-41bd-880a-2ea4dca4c63f"
    />
    * It could be that the `componentProvider` inside `codegenConfig` fix
    the problem
    
    
    I tested it with different versions of React Native and found that
    `ViewManager` is only needed for the old architecture and React Native
    versions below `0.74.x`.
    
    _____
    
    <!-- List the steps with which we can test this change. Provide
    screenshots if this changes anything visual. -->
    
    Co-authored-by: Artur Kalach <[email protected]>
    ArturKalach and ArturKalachEpam authored Jun 21, 2025
    Configuration menu
    Copy the full SHA
    7e7eeed View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ffca33d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    41bb21b View commit details
    Browse the repository at this point in the history
  6. chore: publish

    satya164 committed Jun 21, 2025
    Configuration menu
    Copy the full SHA
    6445bc6 View commit details
    Browse the repository at this point in the history
Loading