Skip to content

Commit ed62777

Browse files
pkuczynskibmenant
authored andcommitted
fix: remove redundant precision from datatype.datetime options (faker-js#335)
1 parent 477ddce commit ed62777

1 file changed

Lines changed: 8 additions & 16 deletions

File tree

src/datatype.ts

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -95,29 +95,21 @@ export class Datatype {
9595
* @method faker.datatype.datetime
9696
* @param options pass min OR max as number of milliseconds since 1. Jan 1970 UTC
9797
*/
98-
datetime(
99-
options?: number | { min?: number; max?: number; precision?: number }
100-
): Date {
101-
if (typeof options === 'number') {
102-
options = {
103-
max: options,
104-
};
105-
}
106-
98+
datetime(options?: number | { min?: number; max?: number }): Date {
10799
const minMax = 8640000000000000;
108100

109-
options = options || {};
101+
let min = typeof options === 'number' ? undefined : options?.min;
102+
let max = typeof options === 'number' ? options : options?.max;
110103

111-
if (typeof options.min === 'undefined' || options.min < minMax * -1) {
112-
options.min = new Date().setFullYear(1990, 1, 1);
104+
if (typeof min === 'undefined' || min < minMax * -1) {
105+
min = new Date().setFullYear(1990, 1, 1);
113106
}
114107

115-
if (typeof options.max === 'undefined' || options.max > minMax) {
116-
options.max = new Date().setFullYear(2100, 1, 1);
108+
if (typeof max === 'undefined' || max > minMax) {
109+
max = new Date().setFullYear(2100, 1, 1);
117110
}
118111

119-
const random = this.faker.datatype.number(options);
120-
return new Date(random);
112+
return new Date(this.faker.datatype.number({ min, max }));
121113
}
122114

123115
/**

0 commit comments

Comments
 (0)